Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“‹ November 2024 (v0.7) release checklist #1117

Open
flanakin opened this issue Nov 11, 2024 · 1 comment
Open

πŸ“‹ November 2024 (v0.7) release checklist #1117

flanakin opened this issue Nov 11, 2024 · 1 comment
Labels
Needs: Triage πŸ” Untriaged issue needs to be reviewed Skill: Deployment Resource deployment automation via bicep or terraform Type: Release πŸš€ Tracks the progress of a release

Comments

@flanakin
Copy link
Collaborator

flanakin commented Nov 11, 2024

Complete the following tasks to publish a monthly release.

πŸ”„οΈ Monthly updates

  • Update open data files (learn more).
    • Pricing units
      1. Run the extraction query.
      2. Replace the contents of the corresponding open data files.
      3. Compare changes and revert any invalid updates.
      4. Re-gen and test PowerShell function: <root>/src/scripts/Build-OpenData.ps1 -PowerShell -Test
      5. Review changes and revert unrelated files or unintended changes.
      6. Document the added/updated rows in the changelog.
      7. Publish a PR for updates
    • Regions
      1. Run the extraction query.
      2. Replace the contents of the corresponding open data files.
      3. Compare changes and revert any invalid updates.
      4. Re-gen and test PowerShell function: <root>/src/scripts/Build-OpenData.ps1 -PowerShell -Test
      5. Review changes and revert unrelated files or unintended changes.
      6. Document the added/updated rows in the changelog.
      7. Publish a PR for updates
    • Services
      1. Run the extraction query.
      2. Replace the contents of the corresponding open data files.
      3. Compare changes and revert any invalid updates.
      4. Re-gen and test PowerShell function: <root>/src/scripts/Build-OpenData.ps1 -PowerShell -Test
      5. Review changes and revert unrelated files or unintended changes.
      6. Document the added/updated rows in the changelog.
      7. Publish a PR for updates
    • Update resource types and re-gen internal PowerShell functions: <root>/src/scripts/Build-OpenData.ps1 -PowerShell -Test
    • Consider automating this process in Build-OpenData.
  • Update Bicep CLI (docs): az bicep upgrade

πŸ”œ Core features

  • Review issues and PRs assigned to the target milestone.
    • Create a new milestone for the next monthly release.
    • Move issues that cannot be resolved in time to a new milestone.
    • Submit PRs for issues that can be resolved.
    • Complete open PRs that are ready to be resolved.
  • Confirm there are no pending changes in dev.
    cd "<root>"
    git checkout dev
    git status
  • Update feature branches and confirm if they're ready for release.
    • Auto-merge feature branch with dev: <root>/src/scripts/Merge-DevBranch.ps1 *
    • Manually update remaining feature branches: <root>/src/scripts/Merge-DevBranch.ps1 features/<name>
      • features/TODO
    • Build and deploy templates: <root>/src/scripts/Build-Toolkit.ps1.
    • Confirm all tests pass: <root>/src/scripts/Test-PowerShell.ps1 -Unit -Integration -Build.
    • Confirm if all features are code complete and not missing any functionality required for release.

      Once in dev, the feature is considered part of the next release and can be pushed out at any time. Any broken features will be reverted.

    • Confirm new or updated functionality is documented in the changelog.

      See Changelog guidance for details about changelog requirements.

    • Confirm new or updated functionality must be documented in the documentation.
    • If adding a new tool, update the list of available tools on the documentation home page.
  • Merge any feature branches that are ready to dev.
    • Create a PR to merge the feature branch into dev.
    • Follow the normal PR process to merge the PR.

πŸ”œ Finalize release

  • Review the changelog to ensure it encapsulates all changes.

    • Move all released changes to an official numbered version section.
    • If there are committed changes in a feature branch that you want to mention, add them to an "Unreleased" section.
  • Update the version: <root>/src/scripts/Update-Version [-Major|Minor|Patch]

  • Build all toolkit templates and resolve any issues: <root>/src/scripts/Build-Toolkit

    This step is optional, but can catch issues earlier. You can also add the -Build parameter to the publish command in the next step.

  • Ensure all tests pass: <root>/src/scripts/Test-PowerShell -Unit -Integration

  • Package all release files

    • Run Package-Toolkit -Build -PowerBI script.

    • For the Cost summary report:

      • Save the file as a PBIX file to the release folder.
      • Change the sensitivity to Public. If the option is disabled, close the file and reopen it.

        ⚠️ Power BI does not remember the sensitivity setting for Power BI projects so this needs to be done for each release. If not done, the report will not open for anyone outside of Microsoft.

      • Remove all but the following queries from Transform data: CostDetails, Prices.
      • Remove the Populate missing prices parameter and its reference from the CostDetails query.
      • Remove the Advisor for disks and Compliance calculation calculated tables.
      • Verify each page has data.
      • Select the Get started page and save the PBIX again in the release folder.

        ⚠️ DO NOT save the above changes back to the Power BI project files!

      • Copy the first paragraph from the Get started page and export a template (PBIT file) in the release folder. Use the copied text for the description and add "Learn more at https://aka.ms/ftk/pbi/{report-name}" as a separate paragraph in the description.
    • For the Data ingestion report:

      • Save the file as a PBIX file to the release folder.
      • Change the sensitivity to Public. If the option is disabled, close the file and reopen it.

        ⚠️ Power BI does not remember the sensitivity setting for Power BI projects so this needs to be done for each release. If not done, the report will not open for anyone outside of Microsoft.

      • Remove all but the following queries from Transform data: CostDetails, Hubs*, Storage*.
      • Remove the Populate missing prices parameter and its reference from the CostDetails query.
      • Remove the Advisor for disks and Compliance calculation calculated tables.
      • Verify each page has data.
      • Select the Get started page and save the PBIX again in the release folder.

        ⚠️ DO NOT save the above changes back to the Power BI project files!

      • Copy the first paragraph from the Get started page and export a template (PBIT file) in the release folder. Use the copied text for the description and add "Learn more at https://aka.ms/ftk/pbi/{report-name}" as a separate paragraph in the description.
    • For the Governance report:

      • Save the file as a PBIX file to the release folder.
      • Change the sensitivity to Public. If the option is disabled, close the file and reopen it.

        ⚠️ Power BI does not remember the sensitivity setting for Power BI projects so this needs to be done for each release. If not done, the report will not open for anyone outside of Microsoft.

      • Remove all but the following queries from Transform data: CostDetails and everything under Resource Graph.
      • Remove the Populate missing prices parameter and its reference from the CostDetails query.
      • Verify each page has data.
      • Select the Get started page and save the PBIX again in the release folder.

        ⚠️ DO NOT save the above changes back to the Power BI project files!

      • Copy the first paragraph from the Get started page and export a template (PBIT file) in the release folder. Use the copied text for the description and add "Learn more at https://aka.ms/ftk/pbi/{report-name}" as a separate paragraph in the description.
    • For the Rate optimization report:

      • Save the file as a PBIX file to the release folder.
      • Change the sensitivity to Public. If the option is disabled, close the file and reopen it.

        ⚠️ Power BI does not remember the sensitivity setting for Power BI projects so this needs to be done for each release. If not done, the report will not open for anyone outside of Microsoft.

      • Remove all but the following queries from Transform data: CostDetails, InstanceSizeFlexibility, Prices, Reservation* and all Resource Graph queries.
      • Remove the Populate missing prices parameter and its reference from the CostDetails query.
      • Remove the Advisor for disks and Compliance calculation calculated tables.
      • Verify each page has data.
      • Select the Get started page and save the PBIX again in the release folder.

        ⚠️ DO NOT save the above changes back to the Power BI project files!

      • Copy the first paragraph from the Get started page and export a template (PBIT file) in the release folder. Use the copied text for the description and add "Learn more at https://aka.ms/ftk/pbi/{report-name}" as a separate paragraph in the description.
    • For the Workload optimization report:

      • Save the file as a PBIX file to the release folder.
      • Change the sensitivity to Public. If the option is disabled, close the file and reopen it.

        ⚠️ Power BI does not remember the sensitivity setting for Power BI projects so this needs to be done for each release. If not done, the report will not open for anyone outside of Microsoft.

      • Remove all but the following queries from Transform data: CostDetails, Prices, AdvisorRecommendations, Disks, NetworkInterfaces, PublicIPAddresses, Resources, Subscriptions, VirtualMachines.
      • Remove the Populate missing prices parameter and its reference from the CostDetails query.
      • Remove the Advisor for disks and Compliance calculation calculated tables.
      • Verify each page has data.
      • Select the Get started page and save the PBIX again in the release folder.

        ⚠️ DO NOT save the above changes back to the Power BI project files!

      • Copy the first paragraph from the Get started page and export a template (PBIT file) in the release folder. Use the copied text for the description and add "Learn more at https://aka.ms/ftk/pbi/{report-name}" as a separate paragraph in the description.
  • Check the docs for broken links:

    • Create a personal fork of the main repo.
    • If you already have one, update it to the latest.
    • Enable GitHub pages in your fork to use the dev branch docs folder.
    • Verify the pages build and deployment action completes successfully.
    • Open a dead link checker (e.g., deadlinkchecker.com) and check https://{your-username}.github.io/finops-toolkit.
      • Ignore link/href errors for new pages that have not been released in the official main branch.
      • Ignore any Download errors for the new release or any new files that haven't been released in the official main branch.
      • Ignore the Full changelog error for the new release, which hasn't been released in the official main branch.
      • Ignore the 403 error for learn.finops.org.
      • Ignore any 429 errors from GitHub. These are caused due to all the contributor links that are checked.
    • Fix any broken links, push changes, and rerun the tool.

πŸ”œ Publish release

  • Publish the PowerShell module by running the Publish PowerShell action.
  • Submit PRs to publish bicep modules in the Bicep Registry.
    • Update your fork and local clone of the Bicep Registry.

      Make sure you're in the main branch of the target repo when publishing a new template. If in another folder, the script will assume you're updating that branch and not create a new one.

    • Publish the scheduled actions bicep modules:
      • Start PR: <root>/src/scripts/Publish-Toolkit.ps1 "scheduledactions" -Commit
      • Complete PR template requirements and set the name to FinOps toolkit v#.# – scheduledactions.
      • Review the code that's changed in the PR, verify that the changelog covers everything, and update as needed.
      • If you make changes, re-publish without committing: <root>/src/scripts/Publish-Toolkit.ps1 "scheduledactions" -Build
      • Switch to the target repo folder and verify your changes were applied correctly.
      • Commit and push your changes.
      • Return to the PR URL and publish the PR.
  • Submit PRs to publish templates to the Azure Quickstart Templates repo.
    • Update your fork and local clone of the Azure Quickstart Templates.

      Make sure you're in the master branch of the target repo when publishing a new template. If in another folder, the script will assume you're updating that branch and not create a new one.

    • Publish a FinOps hub PR:
      • Start PR: <root>/src/scripts/Publish-Toolkit.ps1 "finops-hub" -Commit
      • Complete PR template requirements and set the name to FinOps toolkit v#.# – FinOps hub.
      • Review the code that's changed in the PR, verify that the changelog covers everything, and update as needed.
      • If you make changes, re-publish without committing: <root>/src/scripts/Publish-Toolkit.ps1 "finops-hub" -Build
      • Switch to the target repo folder and verify your changes were applied correctly.
      • Commit and push your changes.
      • Return to the PR URL and publish the PR.
    • Publish a governance workbook PR:
      • Start PR: <root>/src/scripts/Publish-Toolkit.ps1 "governance-workbook" -Commit
      • Complete PR template requirements and set the name to FinOps toolkit v#.# – Governance workbook.
      • Review the code that's changed in the PR, verify that the changelog covers everything, and update as needed.
      • If you make changes, re-publish without committing: <root>/src/scripts/Publish-Toolkit.ps1 "governance-workbook" -Build
      • Switch to the target repo folder and verify your changes were applied correctly.
      • Commit and push your changes.
      • Return to the PR URL and publish the PR.
    • Publish a optimization workbook PR:
      • Start PR: <root>/src/scripts/Publish-Toolkit.ps1 "optimization-workbook" -Commit
      • Complete PR template requirements and set the name to FinOps toolkit v#.# – Optimization workbook.
      • Review the code that's changed in the PR, verify that the changelog covers everything, and update as needed.
      • If you make changes, re-publish without committing: <root>/src/scripts/Publish-Toolkit.ps1 "optimization-workbook" -Build
      • Switch to the target repo folder and verify your changes were applied correctly.
      • Commit and push your changes.
      • Return to the PR URL and publish the PR.
  • Check back after 1 hour to see if there any failed checks across all PRs (AQT).
    • If there are errors, click the Details link to understand what needs to be fixed.
    • Fix any issues in the FinOps toolkit codebase (not in the target repo).
    • Repeat publishing steps until all issues have been resolved.
  • Check back after 2-3 days to see if all your PRs were merged (AQT).

    Bicep Registry and Azure Quickstart Template repos are manually reviewed and closed 2-3x per week. If you don't see an update, contact the ARM team.

  • Merge to main: <root>/src/scripts/Merge-DevBranch.ps1 main
  • Update the milestone.
    • Review all issues in the milestone, move anything that needs to be pushed, and close any completed items.
    • Close the milestone when all issues have been closed or moved.
  • Verify documentation updated correctly.

    The documentation site may take 5 minutes to update after the merge is committed. If not updated, look at GitHub actions to see if there are any failures.

  • Tag and publish a new release:
    • Create a tag on publish using the "vX.X" format.
    • Set the Target to main.
    • Set the Previous tag to the previous release tag.
    • Set the name to Mmm yyyy (v#.#).
    • Copy the body from the previous release to use as a template.
    • Change the "New in" header to use the new version number.
    • Summarize changes from the changelog in the New in and Updated sections.
      • Simplify to only include one line per tool.
      • Each tool should be linked to its doc page.
      • Don't link features to their respective pages (e.g., PowerShell commands).
      • Don't list every small change. Use "various bug fixes and improvements" to keep it simple.
    • Update the list of direct and indirect contributors.
      • Use the "Generate release notes" feature to get a list of all code contributors.
      • Carefully review the list to ensure everyone is covered since feature branch PRs get merged, which can hide contributors.
      • If they made a code change, add them to the contributor list.
      • If they filed an issue, reviewed a PR, or participated in on- or offline discussions, add them to the list of supporters.
    • Update the discussion and changelog links in the footer. Comment out the AQT link if not ready.
    • Upload all files from the release folder:
      • ZIP files for templates like hubs and workbooks.
      • Power BI PBIX and PBIT files.
      • Open data CSV and JSON files.
      • ZIP file for sample data files.
      • DO NOT copy Bicep, PowerShell, PBIP, or image files.
  • Update the related discussion with the same text as the release.
  • Update all issues to Status: Released.

πŸ”œ Post-release clean-up

  • Update the Toolkit / Should return all known releases PowerShell integration test based on the latest version.

    See src/powershell/Tests/Integration/Toolkit.Tests.ps1 > Get-FinOpsToolkitVersion > Should return all known releases

    • Add the latest public version to the $expected variable.
    • Update the file checks to include/exclude any new/removed files.
  • Update the minor version and add the "dev" label: <root>/src/scripts/Update-Version.ps1 -Minor -Label dev
  • Update remaining branches that were not merged with dev
    • TODO: Add branches
    • features/adx
    • features/alerts
    • features/hack24
    • features/mslearn
    • features/private
    • features/ux
  • Confirm the following branches are needed or should be deleted:
    • features/governance
    • features/hourly
    • features/levelup
    • features/powershell
    • features/privateendpoint
    • features/savings
    • features/services

@flanakin flanakin added the Type: Release πŸš€ Tracks the progress of a release label Nov 11, 2024
@flanakin flanakin added this to the 2024-10 - October milestone Nov 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Skill: Deployment Resource deployment automation via bicep or terraform Needs: Triage πŸ” Untriaged issue needs to be reviewed labels Nov 11, 2024
@flanakin
Copy link
Collaborator Author

Branches that did not sync:

  • features/adx (local changes)
  • features/aoe (conflicts)
  • features/exports (conflicts)
  • features/hack24 (conflicts)
  • features/hourly (conflicts)
  • features/mslearn (conflicts)
  • features/private (conflicts)
  • features/savings (local changes)
  • features/ux (local changes)
  • features/workbookv2 (conflicts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage πŸ” Untriaged issue needs to be reviewed Skill: Deployment Resource deployment automation via bicep or terraform Type: Release πŸš€ Tracks the progress of a release
Projects
None yet
Development

No branches or pull requests

1 participant