-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): Create chart web components - Donut and Horizontal Bar Chart #33084
Open
AtishayMsft
wants to merge
69
commits into
master
Choose a base branch
from
charting/web-components
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 67 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
e94bacf
Basic implementation of horizontal bar chart
AtishayMsft e26840b
Add logic for multistacked bar chart
AtishayMsft 027a7ef
Render multi stacked bars
AtishayMsft ee296c0
Color the bars as per provided colors
AtishayMsft 01ca8e4
Charts as Web component (#32866)
Anush2303 ffe7e6f
added callout to multi stacked bar chart (#33013)
Anush2303 4de6c3f
Add web component for donut chart (#33011)
krkshitij aa872c6
Added legend functionality to Horizontal Bar chart (#33051)
Anush2303 0008ba9
Add more functionalities to donut chart (#33039)
krkshitij 66b134b
Move data for HBC to stories
AtishayMsft 0be5e78
Fix styles to use tokens
AtishayMsft 6dc6cb1
Add change file
AtishayMsft 8e14e14
Update d3 dependencies
AtishayMsft d2f76b4
Fix build errors
AtishayMsft faaa036
Fix build errors in HBC
AtishayMsft 9d387da
NM Variant of MultiStacked bar chart (#33086)
Anush2303 f1c9234
Horizontal Bar chart as Web component (#33096)
Anush2303 ce231ed
Add color palette for data visualization (#33095)
krkshitij 17ffa27
Single Bar HBC NM Variant (#33116)
Anush2303 86df4de
Fix bugs in donut-chart web component (#33118)
krkshitij 7d7a3c8
Fix error
AtishayMsft b50e4ba
Move container div to the template
AtishayMsft ee2aacb
Remove unnecessary calls
AtishayMsft 546029d
Add event listeners to legend buttons (#33150)
krkshitij 475f338
Enable gradient in horizontalbarchart (#33151)
krkshitij d0551b8
Update single bar story to use gradient
AtishayMsft c14c048
Resolve review comments
AtishayMsft 415c165
Refactor donut-chart web component (#33149)
krkshitij 86aac7c
Refactor horizontalbarchart web component (#33169)
krkshitij 29da77b
Merge branch 'master' into charting/web-components
AtishayMsft 10c7981
Move charts t web components to own package
AtishayMsft 6baa5bd
Fix CSS class names (#33196)
krkshitij bab162d
Resolve review comments (#33199)
krkshitij e5f44c0
Add benchmark triangle in horizontal-bar-chart (#33207)
krkshitij 72edf75
Add support for custom chart data text in horizontal-bar-chart (#33212)
krkshitij b99009b
bug fixes for horizontal bar chart web component (#33233)
Anush2303 33a5f67
Add change file
AtishayMsft 6bdaee9
Merge branch 'charting/web-components' of https://github.com/microsof…
AtishayMsft 1915d1b
Resolve review comments (#33215)
krkshitij 4753fca
Resolve review comments (#33264)
krkshitij 499b1d2
Merge branch 'master' into charting/web-components
AtishayMsft 66923a5
Update yarn lock
AtishayMsft a57df11
Fix build errors
AtishayMsft a02289e
Added basic test cases to donut chart (#33127)
v-baambati 3049038
Merge master
AtishayMsft 949ff13
Merge branch 'charting/web-components' of https://github.com/microsof…
AtishayMsft 194c051
Fix merge conflict in tsconfig.base.all file
AtishayMsft 5c37d48
Enable chart web components on docsite
AtishayMsft 099247e
removed tabster dependency. (#33285)
Anush2303 8357fcf
Temp change to fix heap out of memory
AtishayMsft cad0f85
Merge branch 'charting/web-components' of https://github.com/microsof…
AtishayMsft b861245
Try updating path
AtishayMsft ef6c184
Test change for react components
AtishayMsft 45db92b
Fix lint errors
AtishayMsft 24d5295
Fix packaging error
AtishayMsft 00511fc
Fix type check error
AtishayMsft 2c24106
Revert adding to web components docsite
AtishayMsft 3abf8b5
Fix errors in tests
AtishayMsft bb66e2f
Test change to fix heap out of memery error
AtishayMsft 2022db6
Set role and aria-label for charts (#33294)
krkshitij 2eda223
Merge master
AtishayMsft 4f40ca8
Merge branch 'charting/web-components' of https://github.com/microsof…
AtishayMsft 7d88390
Revert temp changes
AtishayMsft 785ef83
Update api report
AtishayMsft fcf1184
Update text inside Donut chart fix (#33302)
Anush2303 85a3aa1
Update api report
AtishayMsft 48799bd
high contrast bug fixes (#33326)
Anush2303 a0dd0e8
Order of Stories (#33330)
Anush2303 461b18c
Merge branch 'master' into charting/web-components
AtishayMsft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
change/@fluentui-chart-web-components-dfff0cf0-8ca6-4c11-aacb-bdd0e7090bbb.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "prerelease", | ||
"comment": "Create chart web components. Includes donut chart and horizontal bar chart", | ||
"packageName": "@fluentui/chart-web-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# don't ever lint node_modules | ||
node_modules | ||
# don't lint build output (make sure it's set to your correct build folder name) | ||
dist | ||
# don't lint coverage output | ||
coverage | ||
# don't lint storybook | ||
.storybook |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
{ | ||
"root": true, | ||
"parser": "@typescript-eslint/parser", | ||
"plugins": ["@typescript-eslint", "import"], | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/eslint-recommended", | ||
"plugin:@typescript-eslint/recommended", | ||
"prettier", | ||
"plugin:playwright/recommended" | ||
], | ||
"settings": { | ||
"react": { | ||
"version": "latest" | ||
} | ||
}, | ||
"rules": { | ||
"no-empty": [ | ||
"error", | ||
{ | ||
"allowEmptyCatch": true | ||
} | ||
], | ||
"no-extra-boolean-cast": "off", | ||
"no-prototype-builtins": "off", | ||
"no-fallthrough": "off", | ||
"no-unexpected-multiline": "off", | ||
"no-useless-escape": "off", | ||
"import/order": "error", | ||
"sort-imports": [ | ||
"error", | ||
{ | ||
"ignoreCase": true, | ||
"ignoreDeclarationSort": true | ||
} | ||
], | ||
"comma-dangle": "off", | ||
"@typescript-eslint/no-non-null-assertion": "off", | ||
"@typescript-eslint/no-use-before-define": "off", | ||
"@typescript-eslint/no-empty-interface": "error", | ||
"@typescript-eslint/no-empty-object-type": "off", | ||
"@typescript-eslint/no-unsafe-declaration-merging": "off", | ||
"@typescript-eslint/explicit-module-boundary-types": "off", | ||
"@typescript-eslint/explicit-function-return-type": "off", | ||
"@typescript-eslint/camelcase": "off", | ||
"@typescript-eslint/no-inferrable-types": "off", | ||
"@typescript-eslint/no-unused-vars": [ | ||
"warn", | ||
{ | ||
"args": "none" | ||
} | ||
], | ||
"@typescript-eslint/no-unused-expressions": "warn", | ||
"@typescript-eslint/no-explicit-any": "off", | ||
"@typescript-eslint/naming-convention": [ | ||
"error", | ||
{ | ||
"selector": "default", | ||
"format": ["UPPER_CASE", "camelCase", "PascalCase"], | ||
"leadingUnderscore": "allow" | ||
}, | ||
{ | ||
"selector": "property", | ||
"format": null // disable for property names because of our foo__expanded convention for JSS | ||
// TODO: I think we can come up with a regex that ignores variables with __ in them | ||
}, | ||
{ | ||
"selector": "variable", | ||
"format": null // disable for variable names because of our foo__expanded convention for JSS | ||
// TODO: I think we can come up with a regex that ignores variables with __ in them | ||
} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
test-results/ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Avatar 1 screenshots