Fix nsg concatenation #233
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
hi @vlappenbusch , is this still required? or did the operators changed their format? |
|
Yes, this should still be merged, I wasn't able to get testing put together for it yet but it should be fixed! I believe the operators have a workaround for now |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| concatRule += prefix | ||
| } | ||
| wssdCloudNSGRule.SourceAddressPrefix = concatRule | ||
| wssdCloudNSGRule.SourceAddressPrefix = strings.Join(*rule.SourceAddressPrefixes, ",") |
There was a problem hiding this comment.
Yes, I'll reach out to them to remove those fixes! I believe their fix was to concatenate the arrays themselves and to pass an array with one element that is a concatenated string, so that would still work. I can make sure to notify Arka and whoever else needs to know when this is merged.
There was a problem hiding this comment.
ok, as this is low pri fix, let's hold on and dont merge until we are 100% sure. i would recommend sharing a private with them and testing. for context, our asz private preview is going to happen in 2408 we need to be extra careful with anything we merge.
There was a problem hiding this comment.
Just checked and this won't conflict. Their change is here https://dev.azure.com/msazure/msk8s/_git/moc-operator/pullrequest/10168753?_a=files&path=%2Fpkg%2Fhelper%2Fsecuritygrouphelper.go . The testing is already done and in PR as well, but it needs a version of moc-sdk-for-go before I ask for final reviews
mjethwa-msft
force-pushed
the
user/vlappenbusch/fixNsgConcatenation
branch
2 times, most recently
from
1556802
to
48ec90c
Compare
mjethwa-msft
force-pushed
the
user/vlappenbusch/fixNsgConcatenation
branch
from
48ec90c
to
38bf694
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NSG fields that use multiple inputs, such as SourceAddressPrefixes, should be mapped to a single field by concatenating and comma separating the array into one field. The comma separation was missed, making this SDK work not as intended for inputs with multiple values in the array.
This changes to use comma separation for array input fields, as well as the standardized string concatenation function through golang.