Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM, NIC and disk hydration #237

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

VM, NIC and disk hydration #237

wants to merge 32 commits into from

Conversation

neerajdixit-msft2
Copy link

@neerajdixit-msft2 neerajdixit-msft2 commented Feb 14, 2024 •
edited by mduppre
Loading

This PR is part of the VM, NIC and disk hydration feature that spans the whole HCI stack:

These changes include the protobuf changes required to create a new operation HYDRATE

neerajdixit-msft2 and others added 22 commits February 14, 2024 14:15
@neerajdixit-msft2
protobuf change for node agent VM hydration
2567747
@neerajdixit-msft2
add VM dicovery protobuf changes
f58a10d
@katl-msft
add VM discovery protobuf changes for cloudagent
2c45b36
@katl-msft
add VM discovery protobuf changes for cloudagent
22bb542
@katl-msft
Revert "add VM discovery protobuf changes for cloudagent"
d22f44f 
This reverts commit 2c45b36.
@katl-msft
Merge pull request #256 from microsoft/users/katlynho/VmHydration
2e22ede 
add VM discovery protobuf changes for cloudagent
@neerajdixit-msft2
hydrate vhd object changes
ddd716a
@neerajdixit-msft2
Fix crash in mocctl show, need to uncomment all VM structure members
2595b00
@neerajdixit-msft2
Merge pull request #261 from microsoft/users/ndixit/CloudAgentBugFixes
e0a276d 
Cloud agent bug fixes
@neerajdixit-msft2 @katl-msft
protobuf change for node agent VM hydration
644126d
@neerajdixit-msft2 @katl-msft
add VM dicovery protobuf changes
8e5f774
@katl-msft
add VM discovery protobuf changes for cloudagent
3874ecf
@katl-msft
Revert "add VM discovery protobuf changes for cloudagent"
e7931c7 
This reverts commit 2c45b36.
@katl-msft
add VM discovery protobuf changes for cloudagent
c32f10a
@neerajdixit-msft2 @katl-msft
hydrate vhd object changes
3f56ed6
@neerajdixit-msft2 @katl-msft
Fix crash in mocctl show, need to uncomment all VM structure members
9d385c0
@katl-msft
rebase conflict fixes
f04e8d5
@katl-msft
Merge branch 'users/trailblazer/VmHydration' into users/katlynho/mast…
4881b8d 
…erMerge
@mduppre
Merge pull request #263 from microsoft/users/katlynho/masterMerge
b5ac1e6 
Catch-up merge from master
@mduppre
Update generated go files after catch-up merge with master
d715cb8
@yingzhan-msft
Merge branch 'main' into users/trailblazer/VmHydration
d200305
@mduppre
Remove discovery
ed8ccfc
kybeak
kybeak reviewed Aug 5, 2024
View reviewed changes
pkg/status/status.go Outdated Show resolved Hide resolved
kybeak
kybeak previously approved these changes Aug 9, 2024
View reviewed changes
@neerajdixit-msft2 neerajdixit-msft2 marked this pull request as ready for review August 9, 2024 23:28
@neerajdixit-msft2
Copy link
Author

@damanMSFT can you please review this PR? I have already addressed the previous review comments.

@neerajdixit-msft2 neerajdixit-msft2 changed the title moc protobuf change for node agent VM hydration moc protobuf change for VM hydration Aug 10, 2024
@neerajdixit-msft2
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kybeak
kybeak previously approved these changes Aug 12, 2024
View reviewed changes
@mduppre mduppre changed the title moc protobuf change for VM hydration VM, NIC and disk hydration Sep 7, 2024
kybeak
kybeak reviewed Sep 7, 2024
View reviewed changes
pkg/status/status.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kybeak kybeak kybeak left review comments

@madhanrm madhanrm madhanrm left review comments

@damanMSFT damanMSFT Awaiting requested review from damanMSFT

@jocardeMSFT jocardeMSFT Awaiting requested review from jocardeMSFT

@liwonMS liwonMS Awaiting requested review from liwonMS

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@neerajdixit-msft2 @madhanrm @kybeak @katl-msft @mduppre @yingzhan-msft