Sleep longer to flush queue for sure #4615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4615 +/- ##
==========================================
- Coverage 87.02% 86.91% -0.12%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15103 15083 -20
- Misses 2251 2271 +20 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Oct 15, 2024
| @@ -3656,7 +3656,7 @@ void QuicTestConnectionPriority() | |||
| // e.g. This test case randomly swap [3] and [4] and fail without sleep. | |||
| // This happens when [3] is already in the worker queue. | |||
| // Normal enqueue doesn't re-queue the Connection | |||
| CxPlatSleep(300); | |||
| CxPlatSleep(1000); | |||
There was a problem hiding this comment.
Is there any way to make these event based? Is there some event we could wait on instead?
There was a problem hiding this comment.
Maybe possible by ingesting dummy Operation on dummy Connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ConnectionPriority test has been failing frequently at stream start order validation.
Increase sleep time for actually flush any remaining operations in processing queue
Testing
Try running CI several times
Documentation
N/A