Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Audit log entries are written to files with old timestamps #331

Open
corbin-phipps opened this issue Jul 30, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@corbin-phipps
Copy link
Contributor

Describe the bug
The plog loggers are created in the beginning of src/linux/server/Main::main(), which only gets executed one-time when the netremote server is installed on a system. The date of installation is used for the log file path, e.g. 20240730-LogNetRemote-audit.txt. This means that if netremote is used on a future date (e.g. 20240801), then those log entries will still write to 20240730-LogNetRemote-audit.txt.

Steps To Reproduce

  1. Install netremote-server.
  2. On a future date, perform a Wi-Fi action that causes an entry to be written to the audit log.

Expected behavior
Audit log entries should be written to a log file that has the timestamp of the same date of the log entries themselves.

Actual behavior
Audit log entries are written to the log file that has the timestamp from the installation date.

Example output
cat /var/log/20240724-LogNetRemote-audit.txt
2024-07-24 18:34:18.078 NONE [36787] [main@109] Netremote server starting (log level=info)
2024-07-30 17:25:01.429 INFO [36824] [Microsoft::Net::Wifi::AccessPointControllerLinux::SetOperationalState@159] Operational state of AP wlo1 set to 'disabled'

@corbin-phipps corbin-phipps added the bug Something isn't working label Jul 30, 2024
@abeltrano
Copy link
Contributor

The plog loggers are created in the beginning of src/linux/server/Main::main(), which only gets executed one-time when the netremote server is installed on a system. The date of installation is used for the log file path, e.g. 20240730-LogNetRemote-audit.txt.

As a quick clarification, the loggers are instantiated each time the netremote-server binary is run, and so the date/timestamp will be for that date. This doesn't change the issue described since there can still be a time lag between when the binary was executed and when the test was run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants