[rush] Add warning when using globalIgnoredOptionalDependencies in < pnpm 9.0.0 #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witcher112
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
reviewed
Nov 13, 2024
| @@ -71,6 +72,18 @@ export class InstallHelpers { | |||
| } | |||
|
|
|||
| if (pnpmOptions.globalIgnoredOptionalDependencies) { | |||
| if (rushConfiguration.rushConfigurationJson.pnpmVersion !== undefined && semver.lt(rushConfiguration.rushConfigurationJson.pnpmVersion, '9.0.0')) { | |||
| // eslint-disable-next-line no-console | |||
| console.warn( | |||
There was a problem hiding this comment.
The thing is that there's no terminal accessible in this scope. Should I rework the code a bit so it's passed down and accessible here or create a new instance of it?
There was a problem hiding this comment.
If that's easy enough to do, go for it, otherwise don't worry about it.
...es/@microsoft/rush/warn-about-ignored-optional-dependencies-pnpm-pre-9_2024-11-09-12-28.json
Outdated
Show resolved
Hide resolved
…endencies-pnpm-pre-9_2024-11-09-12-28.json Co-authored-by: Ian Clanton-Thuon <[email protected]>
Co-authored-by: Ian Clanton-Thuon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"globalIgnoredOptionalDependencies" doesn't work if Rush monorepo is not configured with pnpm 9+.
Details
I've added mentions about it in the schema and a warning during rush install/update.
How it was tested
Impacted documentation
https://rushjs.io/pages/configs/pnpm-config_json/