Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Titlebar when System Theme Changes #17457

Open
KubaP opened this issue Jun 20, 2024 · 2 comments
Open

Duplicate Titlebar when System Theme Changes #17457

KubaP opened this issue Jun 20, 2024 · 2 comments
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.

Comments

@KubaP
Copy link

KubaP commented Jun 20, 2024

Windows Terminal version

1.20.11381.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

  1. Open a new Windows Terminal window
  2. Close the window
  3. Change the Windows application theme (in either direction)
  4. Open a new Windows Terminal window again
  5. See the duplicated title bar
    7lb27k8HVO

Expected Behavior

No response

Actual Behavior

How to trigger this

When the Windows application theme changes (light<->dark), and a quake mode WT instance is running in the background, upon opening a new instance of Windows Terminal, two titlebars are present.

This happens if and only if a WT window (other than the quake window) was opened and closed before the theme change, and a new WT window is opened after the theme change.

If the theme change happens whilst a WT window is open, the application colours change correctly and the titlebar isn't duplicated for the existing window. However, opening a new WT window will show the extra titlebar.

Fixing this through the titlebar

Interacting with either titlebar (hitting the minimize or maximize buttons) makes the extra titlebar disappear and retains only the WT titlebar. However, hitting either close button, and then opening a new WT window, the extra titlebar is still present.

Fixing this through the setting

Toggling the Appearance > Hide the titlebar setting from On to Off, and closing the affected window, when opening a new WT window, the two titlebars are still present but weirdly overlapping:
image
Then, toggling the aforementioned setting from Off back to On, and closing the affected window, when opening a new WT window the extra titlebar is not present.

When does it happen again

Once the duplicate titlebar disappears, it won't appear again until another theme change.

@KubaP KubaP added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 20, 2024
@KubaP
Copy link
Author

KubaP commented Jun 20, 2024

I forgot to mention, I have never seen any other program duplicate its titlebar when changing the windows application theme (and I have a script that changes the theme daily to match day/night), hence I believe this is a bug with Windows Terminal.

@PankajBhojwani PankajBhojwani added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-2 A description (P2) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 26, 2024
@PankajBhojwani PankajBhojwani added this to the Terminal v1.22 milestone Jun 26, 2024
@DHowett
Copy link
Member

DHowett commented Oct 9, 2024

This is almost certainly related to refrigeration (which is what we call "keeping a window object around on Windows 10 and using them instead of making new ones" (which we do because of a crash in WinUI...))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants