Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific theme for profile #17985

Closed
pwsandoval opened this issue Oct 2, 2024 · 2 comments
Closed

Specific theme for profile #17985

pwsandoval opened this issue Oct 2, 2024 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@pwsandoval
Copy link

pwsandoval commented Oct 2, 2024

Windows Terminal version

1.21.2701.0

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

I know I can create multiple themes and define which one to use like this:

"theme": "dark"
"themes":
[
    {
      "name": "dark",
      "window": {
          "applicationTheme": "dark"
      },
      "tab": {
          "background": "terminalBackground",
          "unfocusedBackground": "#00000000"
      },
      "tabRow": {
          "unfocusedBackground": "#333333FF"
      }
  }
]

But how do I assign a different theme to a profile (as I do with the colorScheme), I want the window color to be integrated, if this is in WSL everything should be orange and if I am in PowerShell Black, I have not achieved it, but I think it is possible because in this link, there is a gif that does exactly this:

https://learn.microsoft.com/en-us/windows/terminal/custom-terminal-gallery/theme-gallery

image

Expected Behavior

In Powershell the tabs and windows are blue, in Ubuntu purple, and in cmd black.

Actual Behavior

My config is as follows

"profiles": {
    "defaults": { "colorScheme": "Everblush" }
"list": [
{
        "commandline": "pwsh.exe -nologo",
        "guid": "{59e30915-7255-4c37-aac8-65e9eb49caa6}",
        "hidden": false,
        "icon": "ms-appx:///ProfileIcons/pwsh.png",
        "name": "PowerShell",
        "startingDirectory": "%USERPROFILE%"
      },
{
        "guid": "{10e14319-4cbb-4efc-95f8-4d48fdafdb75}",
        "name": "Plex",
        "icon": "%USERPROFILE%\\Pictures\\icons\\plex.ico",
        "hidden": false,
        "commandline": "ssh -i %USERPROFILE%\\.ssh\\private pw@localhost",
        "colorScheme": "Plex",
        "theme": "Plex" // This line has no effect, I want use only for this profile
      },
{
...
"themes": [
    {
      "name": "Everblush", // This is global theme
      "tab": {
        "background": "#141B1EFF",
        "iconStyle": "default",
        "showCloseButton": "always",
        "unfocusedBackground": "#232A2DFF"
      },
      "tabRow": {
        "background": "#232A2DFF",
        "unfocusedBackground": "#232A2DFF"
      },
      "window": {
        "applicationTheme": "dark",
        "experimental.rainbowFrame": false,
        "frame": null,
        "unfocusedFrame": null,
        "useMica": false
      }
    },
    {
      "name": "Plex", // Theme for only Plex profile
      "tab": {
        "background": "#141B1EFF",
        "iconStyle": "default",
        "showCloseButton": "always",
        "unfocusedBackground": "#232A2DFF"
      },
      "tabRow": {
        "background": "#232A2DFF",
        "unfocusedBackground": "#232A2DFF"
      },
      "window": {
        "applicationTheme": "dark",
        "experimental.rainbowFrame": false,
        "frame": null,
        "unfocusedFrame": null,
        "useMica": false
      }
    }
}
@pwsandoval pwsandoval added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 2, 2024
@ketan270

This comment has been minimized.

@DHowett
Copy link
Member

DHowett commented Oct 9, 2024

"tabRow": {
       "background": "#232A2DFF",

If you set the background to terminalBackground, just like in your first post, it will use the same color as the profile.

@DHowett DHowett closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants