Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snapOnInput more flexible (i.e. do not snap on mouse paste, but snap on Enter) #17992

Open
phil-blain opened this issue Oct 3, 2024 · 2 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Product-Terminal The new Windows Terminal.
Milestone

Comments

@phil-blain
Copy link

Description of the new feature/enhancement

Often, I find myself scrolling up to copy stuff from earlier commands, e.g. long paths (I do that by selecting them). I would like to be able to paste them (I do that using right click) at the current prompt, but without snapping back to the prompt (i.e. what happens with "snapOnInput": false), but then I would also like that if I type stuff to tweak the command I'm writing, or hit Enter to execute it, then Terminal snaps to it (i.e. what happens with "snapOnInput": true).

Proposed technical implementation details (optional)

Maybe "snapOnInput": "keyboard"|"mouse"|"all", with the current true behaviour equivalent to "all", and the one I describe above would be "keyboard".

@phil-blain phil-blain added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 3, 2024
@carlos-zamora
Copy link
Member

Thanks for filing! Some questions from the team:

  • What about for sendInput actions?
  • What if the action is bound to a key vs the menu?
  • What about paste by keyboard (ctrl+shift+v)?

We like the idea of this feature, there's just some concerns about the way we'd expose it because there's various ways to generate input (i.e. paste via keyboard, paste via mouse, sendInput, etc.). We'd love to hear your thoughts 😊

@carlos-zamora carlos-zamora added this to the Backlog milestone Oct 9, 2024
@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 9, 2024
@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Oct 25, 2024
@phil-blain
Copy link
Author

I'm not sure how to answer these questions. I'm not sure what sendInput does...

I'm mostly missing how other terminals I use work (mostly Konsole and GNOME Terminal). In these, I can scroll up and select-to-copy then middle-mouse-click-to-paste, and it does not snap me back to the prompt. I find this feature useful when constructing a command line from content in my scroll history (like long paths). Then as soon as use the keyboard it does scroll back down to the prompt.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants