Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement codefix for MSTEST0037: Use proper 'Assert' methods #4162

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implement codefix for MSTEST0037: Use proper 'Assert' methods #4162

wants to merge 6 commits into from
+917 −62

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 26, 2024 •
edited
Loading

Fixes #3315

Evangelink
Evangelink reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the cases leading to compilation error, could we tweak the rule not to report instead?

test/UnitTests/MSTest.Analyzers.UnitTests/UseProperAssertMethodsAnalyzerTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.Analyzers.UnitTests/UseProperAssertMethodsAnalyzerTests.cs Outdated Show resolved Hide resolved
Evangelink
Evangelink reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please rename the few variables with numbering suffix.

src/Analyzers/MSTest.Analyzers.CodeFixes/UseProperAssertMethodsFixer.cs Outdated Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers.CodeFixes/UseProperAssertMethodsFixer.cs Outdated Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers.CodeFixes/UseProperAssertMethodsFixer.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: Analyzers Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new Analyzer+CodeFix: recommend against wrong assertion method (e.g. Assert.IsTrue(x != null))
2 participants
@Youssef1313 @Evangelink