Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxplat: use of inline functions and macros #90

Open
dthaler opened this issue Aug 22, 2023 · 0 comments
Open

cxplat: use of inline functions and macros #90

dthaler opened this issue Aug 22, 2023 · 0 comments

Comments

@dthaler
Copy link
Contributor

dthaler commented Aug 22, 2023

In #89, comments ehre:

Nick: General question though: Can/should we move stuff to be header only (via macros or possibly inline functions) instead of functions defined in separate files? Ideally the linker should do a good job of eliminating overhead, but it doesn't always do it perfect.

Dave: The downside of macros/inlines is that if they're non-trivial and used a lot, then they can increase the footprint and memory requirements. So I would say: yes for trivial functions, no for complex functions. Can do a pass in a separate PR.

@dthaler dthaler changed the title cxplat: cxplat: use of inline functions Aug 22, 2023
@dthaler dthaler changed the title cxplat: use of inline functions cxplat: use of inline functions and macros Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant