-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update macOS to 13.5 and xcode 14.3.1. #33722
Conversation
Remove references to the sshfs stuff we no longer use. Change instructions to no longer need to install powershell or deploy a vcpkg clone on the hosts.
This port has so much vendored stuff and is no longer maintained so I think it should probably be deindexed but this is enough for now. ``` /Users/vagrant/Data/buildtrees/urho3d/src/3eb4f765c8-520911ca5c.clean/Source/ThirdParty/SDL/src/file/cocoa/SDL_rwopsbundlesupport.m /Users/vagrant/Data/buildtrees/urho3d/src/3eb4f765c8-520911ca5c.clean/Source/ThirdParty/SDL/src/file/cocoa/SDL_rwopsbundlesupport.m:45:20: error: mixing declarations and code is incompatible with standards before C99 [-Werror,-Wdeclaration-after-statement] NSFileManager* file_manager = [NSFileManager defaultManager]; ^ 1 error generated. ```
REGRESSION: arrayfire:x64-osx failed with BUILD_FAILED. If expected, add arrayfire:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt.
This looks like some form of macos tooling bug. This port has also been extremely flaky in the past, I'm skipping it. Also relatively unpopular; installed 0.07% as frequently as zlib. REGRESSION: blitz:x64-osx failed with BUILD_FAILED. If expected, add blitz:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt. Python 2 is dead. REGRESSION: libtorch:x64-osx failed with BUILD_FAILED. If expected, add libtorch:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt.
Looks fixed by pytorch/pytorch@9590cf6 ? Cherry-picked. REGRESSION: coroutine:x64-osx failed with BUILD_FAILED. If expected, add coroutine:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt. Filed luncliff/coroutine#61 , baselined. REGRESSION: tensorflow:x64-osx failed with BUILD_FAILED. If expected, add tensorflow:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt.
Tensorflow's attempt to force boringssl appears to now disagree with the system openssl. Likely this has always been broken, and Bazel is making it very hard to force tensorflow to use the copy of openssl from vcpkg. This isn't an infrastructure issue, and we've been talking about turning off tensorflow on osx for a while now as it takes 8 hours to build, so I'm baselining these. REGRESSION: urho3d:x64-osx failed with BUILD_FAILED. If expected, add urho3d:x64-osx=fail to /Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt. Turns on a -Werror flag that is broken, patched out. PASSING, REMOVE FROM FAIL LIST: bgfx:x64-osx (/Users/vagrant/Data/work/2/s/scripts/azure-pipelines/../ci.baseline.txt). :) |
@@ -2,7 +2,7 @@ | |||
"$note": "Due to the upstream modification of the dependent source code, the internal port of vcpkg cannot be used.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this means 'urho3d cannot be in the curated registry at all' but that should be its own change.
I give up trying to ninja-patch libtorch, seems to be an understood problem upstream: pytorch/pytorch#100991 2.x update should fix |
tensorflow:x64-osx=skip | ||
tensorflow:arm-osx=skip | ||
tensorflow-cc:x64-osx=skip | ||
tensorflow-cc:arm-osx=skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tensorflow ports are really bad. Building libs and tools for host and target, with many vendored dependencies. (More obvious for windows, where there are always some parts which seem to pick the wrong CRT.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah; I think there are some users of them on Windows or Linux where that we build from source effectively gives them -march=native
which is a big perf reason to use us. But I don't think those folks have been looking to macos for a long time.
The 'google-y' projects just really hate working with anything that is not their internal build assumptions and it shows :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(We were considering turning off tensorflow builds on macos just due to the build time anyway so this was not a difficult decision)
Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=101160&view=results Added `blitz` to ci.baseline.txt by #33722, which has been fixed by #37723. ``` PASSING, REMOVE FROM FAIL LIST: blitz:x64-osx ```
Remove references to the sshfs stuff we no longer use. Change instructions to no longer need to install powershell or deploy a vcpkg clone on the hosts.