Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.4.0 Endgame #179

Closed
16 tasks done
akaroml opened this issue Nov 29, 2017 · 11 comments
Closed
16 tasks done

0.4.0 Endgame #179

akaroml opened this issue Nov 29, 2017 · 11 comments
Assignees
@ansyral @testforstephen @akaroml @andxu @yaohaizh @bsaby
Milestone
0.4.0

Comments

@akaroml
Copy link
Member

akaroml commented Nov 29, 2017 •
edited by testforstephen
Loading

Build

Test

  • 11/30 - Run test plan Test Plan vscjavaci/java-debug-ci#17 - @bsaby
  • 11/30 - Test generic Java 8 and 9 support on the Mac - @testforstephen
  • 11/30 - Test generic Java 8 and 9 support on the Linux/Ubuntu- @yaohaizh
  • 11/30 - Test cwd/environment variables support on the Windows - @yaohaizh
  • 11/30 - Test single file debugging support on the Windows (cannot see compilation errors)- @yaohaizh
  • 11/30 - Test hex/showQualifiedNames/static user settings - @testforstephen
  • 11/30 - Test auto resolve main class and module paths for java 9 project - @yaohaizh
  • 11/30 - Test generic Java 8 and 9 support on the Windows - @ansyral
  • 11/30 - Test on the VSCode insider - @ansyral
  • 11/30 - Test debugging support for popular projects (e.g. spring boot/docker) - @akaroml
  • 11/30 - Test launchInTerminal support - @yaohaizh

Release

Notes

Before you check an item, please reply to this issue with the following details:

  1. What are the steps and details of your check?
  2. What are the configurations?
  3. What are the issues found in the process?
  4. What's your conclusion?
@akaroml akaroml added the eng label Nov 29, 2017
@akaroml akaroml added this to the 0.4.0 milestone Nov 29, 2017
@yaohaizh
Copy link
Contributor

yaohaizh commented Nov 30, 2017 •
edited
Loading

Ubuntu

  • OS: Ubuntu 17.10
  • VSCode: 1.18.1

Java 8:

  • Following the steps from here: Test Plan vscjavaci/java-debug-ci#17
  • The basic functions work as expected: Breakpoints/threads/callstack/variable
  • Maven: Newly generated & spring-petclinic works correctly with debugging features.
  • Gradle & Single file: Press F5 without issues.

Java 9:

  • Following the steps from here: Test Plan vscjavaci/java-debug-ci#17
  • The basic functions work as expected: Breakpoints/threads/callstack/variable
  • Maven: Newly generated works correctly with debugging features.(Spring not supported on Java 9 yet)
  • Single file: Press F5 without issues.

@yaohaizh
Copy link
Contributor

yaohaizh commented Nov 30, 2017 •
edited
Loading

launchInTerminal

  • Java 8, OS: Ubuntu 17.10, VSCode: 1.18.1, all three options work as expected from the test plan
  • Java 9, OS: Ubuntu 17.10, VSCode: 1.18.1, all three options work as expected from the test plan

@ansyral
Copy link
Contributor

ansyral commented Nov 30, 2017

Windows

  • Windows 10
  • VSCode 1.19.0-insider

java9 jdk

  1. debug without launch.json
  2. hit breakpoint
  1. create launch.json automatically
  2. hit breakpoint

@testforstephen
Copy link
Contributor

testforstephen commented Nov 30, 2017 •
edited
Loading

Mac

Installing build 36 RC bits on VSCode 1.8.1 succeed.

jdk 9.0.1

  1. Open 23.console-app project.
  2. Launch the program with the default debug console. [Pass]
  3. Basic debug features (breakpoint, step, start, stop) work. [Pass]
  4. Change console to integratedTerminal, restart the debugger.
    • Sometimes the program is paused on exception even if i didn't set any exception breakpoint. Open 2 bugs #183 #182
    • But if i choose to continue the exception breakpoint, the program run normally. And i can type input in integrated terminal for the program. [Pass]
  5. Change console to externalTerminal, restart the debugger. It has similar exception breakpoint issue, but the program could pop up the external terminal successfully. [Pass]

jdk 1.8.0

  1. Open Spring pet-clinic project.
  2. Press F5 to start debug without breakpoint, and the application is started in 10.533 seconds.
  3. Enable stopOnEntry switch on launch.json, and restart debugger. The application is started in 9.924 seconds. Don't get perf issue for stopOnEntry feature. [Pass]

@yaohaizh
Copy link
Contributor

Single File

  • Windows 10 X64, VSCode 1.18.1, work as expected
  • Ubuntu 17.10, VSCode 1.18.1 work as expected

@yaohaizh
Copy link
Contributor

yaohaizh commented Nov 30, 2017 •
edited
Loading

Test cwd/environment variables support on the Windows

  • CWD works after set in launch.json with System.getProperty("user.dir") to get value.
  • Env: value set in env can be correctly fetch with System.getEnv("testingKey")

@bsaby
Copy link
Contributor

bsaby commented Nov 30, 2017 •
edited
Loading

Run test plan

Following the steps from here: vscjavaci/java-debug-ci#17

  1. Configurations
Platform Win10 x64 Win10 x86 Win10 x64 Mac Mac Ubuntu
Configurations VSCode 1.18.1 x64 JDK8 x64 VSCode 1.18.1 x86 JDK8 x86 VSCode 1.18.1 x64 JDK9 x64 VSCode 1.18.1 JDK8 x64 VSCode 1.18.1 JDK9 x64 VSCode 1.18.1 x64 JDK8 x64
  1. Open new bugs:
  1. Test result details:
Test case Win10 x64 Win10 x86 Win10 x64 Mac Mac Ubuntu
Configurations VSCode 1.18.1 x64 JDK8 x64 VSCode 1.18.1 x86 JDK8 x86 VSCode 1.18.1 x64 JDK9 x64 VSCode 1.18.1 JDK8 x64 VSCode 1.18.1 JDK9 x64 VSCode 1.18.1 x64 JDK8 x64
Clean install Pass Pass Pass Pass Pass Pass
Uninstall Pass Pass Pass Pass Pass Pass
Update Pass Pass Pass Pass Pass Pass
Auto generating launch.json Pass Pass #125 Pass #125 Pass
HelloWorld Pass Pass Pass Pass Pass Pass
CallStack Pass Pass Pass Pass Pass Pass
Multiple Thread Pass Pass Pass Pass Pass Pass
Variables Pass Pass Pass Pass Pass Pass
Big stack frame Pass Pass Pass Pass Pass Pass
Breakpoint and inner class Pass Pass Pass Pass Pass Pass
Variable performance test Pass Pass Pass Pass Pass Pass
No debug information test Pass Pass Pass Pass Pass Pass
Maven test Pass Pass Pass Pass Pass Pass
Gradle test Pass Pass #134 Pass #134 #134
PetClinc Pass Pass #168 Pass #168 Pass
TODO application Pass Pass microsoft/todo-app-java-on-azure#28 [New] Pass microsoft/todo-app-java-on-azure#28 [New] Pass
Single file build Pass Pass #184 [New] Pass #184 [New] Pass
Console application #185 [New] #185 [New] #185 [New] Pass Pass Pass
Java 9 modular application \ \ Pass \ Pass \
Multi-root Pass Pass Pass Pass #125 Pass

@yaohaizh
Copy link
Contributor

Test auto resolve main class and module paths for java 9 project

  • Ubuntu, can correclty resolve the main classes
  • Windows can correclty resolve the main classes

@testforstephen
Copy link
Contributor

Test hex/showQualifiedNames/static user settings

  1. On Mac, open 4.variable project on VSCode.
  2. Enable java.debug.settings.showHex and java.debug.settings.showQualifiedNames in user settings, the variable format will change too.

@testforstephen
Copy link
Contributor

testforstephen commented Nov 30, 2017 •
edited
Loading

Spring on docker

  1. Follow the doc to debug gs-spring-boot-docker, at first it show corrupt app.jar, then change the Dockfile as below:
    image
    It works. [Pass]
  2. Set a breakpoint, it can be hit. [Pass]

@testforstephen
Copy link
Contributor

0.4.0 has released, close this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansyral ansyral

@testforstephen testforstephen

@akaroml akaroml

@andxu andxu

@yaohaizh yaohaizh

@bsaby bsaby

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
6 participants
@ansyral @testforstephen @akaroml @andxu @yaohaizh @bsaby