Buffer deprecated warning #136874

alyssajotice · 2021-11-10T15:07:13Z

Does this issue occur when all extensions are disabled?: Yes

Version: 1.63.0-insider (user setup)
Commit: a7104f1
Date: 2021-11-08T05:14:49.440Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

Steps to Reproduce:

Run VS Code or VS Code Insiders with the flag --disable-extensions
Observe developer tools console

Expected: No error messages or warnings

Actual: (node:22768) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.(Use Code - Insiders --trace-deprecation ... to show where the warning was created).

Running code-insiders --trace-deprecation results in this message: Warning: 'trace-deprecation' is not in the list of known options, but still passed to Electron/Chromium.

According to one of Live Share's commenters, this is where the issue may be coming from: microsoft/live-share#3331 (comment)

The text was updated successfully, but these errors were encountered:

mrnossiom · 2021-11-10T15:12:40Z

Try to pass --trace-deprecation as an NODE_OPTION. Like this:

$env:NODE_ENV="--trace-deprecation" code-insiders
// The dollar goes with the command...

I saw you were on Windows, but for Linux it is just NODE_OPTIONS="--trace-deprecation" code-insiders

alyssajotice · 2021-11-10T15:18:18Z

$ set NODE_ENV="--trace-deprecation" code-insiders
$ NODE_ENV="--trace-deprecation" code-insiders
$ set NODE_OPTION="--trace-deprecation" code-insiders
$ code-insiders --trace-deprecation
Warning: 'trace-deprecation' is not in the list of known options, but still passed to Electron/Chromium.

Is there something else I should try?

mrnossiom · 2021-11-10T15:19:36Z

Well if any of these don't work, idk.

bpasero · 2021-11-10T16:58:48Z

Probably #82524

sandy081 · 2021-11-11T13:46:21Z

I do not think it is related to #82524 because in the other, warning is shown only while installing the extension.

bpasero · 2021-11-11T16:29:14Z

Adding process.traceDeprecation = true; to the beginning of exensionHostProcess reveals this:

ERR [Extension Host] (node:3777) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:194:11)
    at new Buffer (buffer.js:281:3)
    at Object.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/ftp/lib/connection.js:52:17)
    at Module.u._compile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:1316)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10)
    at Module.load (internal/modules/cjs/loader.js:982:32)
    at Module._load (internal/modules/cjs/loader.js:823:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:1006:19)
    at h (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:699)
    at Object.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/get-uri/dist/ftp.js:16:31)
    at Module.u._compile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:1316)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10)
    at Module.load (internal/modules/cjs/loader.js:982:32)
    at Module._load (internal/modules/cjs/loader.js:823:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:1006:19)
    at h (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:699)
    at Object.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/get-uri/dist/index.js:10:31)
    at Module.u._compile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:1316)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10)
    at Module.load (internal/modules/cjs/loader.js:982:32)
    at Module._load (internal/modules/cjs/loader.js:823:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:1006:19)
    at h (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:699)
    at Object.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-proxy-agent/out/agent.js:17:35)
    at Module.u._compile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:1316)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10)
    at Module.load (internal/modules/cjs/loader.js:982:32)
    at Module._load (internal/modules/cjs/loader.js:823:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:1006:19)
    at h (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:699)
    at Object.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/node_modules.asar/vscode-proxy-agent/out/index.js:40:30)
    at Module.u._compile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:1316)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10)
    at Module.load (internal/modules/cjs/loader.js:982:32)
    at Module._load (internal/modules/cjs/loader.js:823:14)
    at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
    at Module.require (internal/modules/cjs/loader.js:1006:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at r (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:5:101)
    at e.load (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:1723)
    at e.load (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:3:10695)
    at d (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:5:10300)
    at i._loadModule (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:5:10430)
    at i._resolve (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:6:452)
    at i.defineModule (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:5:6142)
    at v (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:6:1702)
    at g (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:2557)
    at Object.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:106:58294)
    at Object.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:116:32793)
    at e._createAndEvalScript (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:2601)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:2240
    at h (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:4192)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:4386
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63:3)

bpasero · 2021-11-11T16:29:41Z

@chrmarti maybe we can fix this in our vscode-proxy-agent

chrmarti · 2021-11-15T10:58:23Z

Also tracked as TooTallNate/node-get-uri#18 and mscdex/node-ftp#255.

kanlukasz · 2021-11-15T11:02:21Z

Some time ago your bot closed my issue about this (I still don't know why ...)
Here ---> #123180

Angelo-yu · 2021-11-24T06:52:07Z

[error] [Extension Host] (node:61654) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use Code Helper (Renderer) --trace-deprecation ... to show where the warning was created)

I have also encountered the same problem, I am using a Macbook Pro with M1 chip, the system is the latest macOS Monterey 12.0.1 (21A559) VS Code version 1.62.3, I tried to delete all the extensions, but the problem still exists.
My English is not very good, I used the translation tool to translate the above text, if there is inaccurate expression, please forgive me!

Angelo-yu · 2021-11-24T06:54:46Z

jasonwilliams · 2021-11-25T07:31:09Z

Also tracked as TooTallNate/node-get-uri#18 and mscdex/node-ftp#255.

Looks like that node-ftp project is dead. Despite there being a fix and PR, nothing has been merged since 2015. I don’t see an alternative either.

chrmarti · 2021-11-25T08:34:08Z

Looking closer, we might not actually need node-get-uri. I'll investigate.

bpasero · 2022-02-04T17:59:59Z

👏 👏 👏

alyssajotice mentioned this issue Nov 10, 2021

DeprecationWarning: Buffer() is deprecated due to security and usability issues microsoft/live-share#3331

Closed

vscode-triage-bot assigned weinand Nov 10, 2021

weinand removed their assignment Nov 10, 2021

chrmarti assigned sandy081 Nov 11, 2021

sandy081 removed their assignment Nov 11, 2021

bpasero assigned chrmarti Nov 11, 2021

chrmarti added bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 15, 2021

chrmarti added this to the November 2021 milestone Nov 25, 2021

chrmarti modified the milestones: November 2021, December 2021 Dec 3, 2021

itsxallwater mentioned this issue Dec 7, 2021

VS Code 1.62 breaks the extension. Downgrade to 1.61 mvextensions/mvbasic#162

Closed

weinand mentioned this issue Jan 17, 2022

Deprecation warning that cannot show where created #140848

Closed

chrmarti mentioned this issue Jan 25, 2022

"vscode-proxy-agent" failed #141358

Closed

chrmarti modified the milestones: January 2022, February 2022 Jan 28, 2022

chrmarti closed this as completed in microsoft/vscode-proxy-agent@07c22a9 Feb 4, 2022

chrmarti added a commit that referenced this issue Feb 4, 2022

Update vscode-proxy-agent (#136874)

b319bb9

chrmarti removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Feb 4, 2022

rzhao271 mentioned this issue Feb 4, 2022

DeprecationWarning: Buffer() is deprecated due to security and usability issues. #142227

Closed

gjsjohnmurray mentioned this issue Feb 21, 2022

[DEP0005] DeprecationWarning #143535

Closed

jrieken added the verified Verification succeeded label Feb 23, 2022

github-actions bot locked and limited conversation to collaborators Mar 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buffer deprecated warning #136874

Buffer deprecated warning #136874

alyssajotice commented Nov 10, 2021 •

edited

Loading

mrnossiom commented Nov 10, 2021 •

edited

Loading

alyssajotice commented Nov 10, 2021

mrnossiom commented Nov 10, 2021

bpasero commented Nov 10, 2021

sandy081 commented Nov 11, 2021

bpasero commented Nov 11, 2021

bpasero commented Nov 11, 2021

chrmarti commented Nov 15, 2021

kanlukasz commented Nov 15, 2021

Angelo-yu commented Nov 24, 2021

Angelo-yu commented Nov 24, 2021

jasonwilliams commented Nov 25, 2021 •

edited

Loading

chrmarti commented Nov 25, 2021

bpasero commented Feb 4, 2022

Buffer deprecated warning #136874

Buffer deprecated warning #136874

Comments

alyssajotice commented Nov 10, 2021 • edited Loading

mrnossiom commented Nov 10, 2021 • edited Loading

alyssajotice commented Nov 10, 2021

mrnossiom commented Nov 10, 2021

bpasero commented Nov 10, 2021

sandy081 commented Nov 11, 2021

bpasero commented Nov 11, 2021

bpasero commented Nov 11, 2021

chrmarti commented Nov 15, 2021

kanlukasz commented Nov 15, 2021

Angelo-yu commented Nov 24, 2021

Angelo-yu commented Nov 24, 2021

jasonwilliams commented Nov 25, 2021 • edited Loading

chrmarti commented Nov 25, 2021

bpasero commented Feb 4, 2022

alyssajotice commented Nov 10, 2021 •

edited

Loading

mrnossiom commented Nov 10, 2021 •

edited

Loading

jasonwilliams commented Nov 25, 2021 •

edited

Loading