Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little fixes to Image Search App #1466

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Little fixes to Image Search App #1466

merged 3 commits into from
Nov 26, 2024

Conversation

dnoliver
Copy link
Contributor

  • A reference to a related issue in your repository.

#1465

  • A description of the changes proposed in the pull request.

Address the issues described in #1465

  • Add delight to the experience when all tasks are complete 🎉

* use_column_width is deprecated
* replacing it with use_container_width
* Add dataset folder and zip file to gitignore
* Remove <> characters from repo url
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dnoliver

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link

Welcome @dnoliver! It looks like this is your first PR to milvus-io/bootcamp 🎉

@wxywb wxywb self-requested a review November 26, 2024 02:06
@wxywb wxywb merged commit 9d8d8bd into milvus-io:master Nov 26, 2024
2 checks passed
@wxywb
Copy link
Collaborator

wxywb commented Nov 26, 2024

Thanks for your contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants