-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: used wrong label for query received_nq metrics #37987
base: master
Are you sure you want to change the base?
Conversation
@Reidddddd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@Reidddddd Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
08da79c
to
58caa75
Compare
issue: milvus-io#37982 Signed-off-by: Reid Chan <[email protected]>
@Reidddddd go-sdk check failed, comment |
@Reidddddd cpp-unit-test check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37987 +/- ##
==========================================
+ Coverage 79.00% 81.07% +2.07%
==========================================
Files 1352 1360 +8
Lines 189537 190776 +1239
==========================================
+ Hits 149739 154676 +4937
+ Misses 34341 30621 -3720
- Partials 5457 5479 +22
|
@Reidddddd E2e jenkins job failed, comment |
rerun go-sdk |
rerun cpp-unit-test |
/run-cpu-e2e |
1 similar comment
/run-cpu-e2e |
failed with seems not relevant |
Hi @xiaofan-luan , can please take a look, a very simple patch |
/run-cpu-e2e |
@Reidddddd |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Reidddddd, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Reidddddd E2e jenkins job failed, comment |
Issue is here: #37982 |
No description provided.