Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: used wrong label for query received_nq metrics #37987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Reidddddd
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@Reidddddd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@Reidddddd

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Nov 25, 2024
@Reidddddd Reidddddd changed the title [Bug]: used wrong label for query received_nq metrics (#37982) fix: used wrong label for query received_nq metrics (#37982) Nov 25, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@Reidddddd Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@Reidddddd Reidddddd changed the title fix: used wrong label for query received_nq metrics (#37982) fix: used wrong label for query received_nq metrics Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@Reidddddd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@Reidddddd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (e76802f) to head (2cc7427).
Report is 46 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37987      +/-   ##
==========================================
+ Coverage   79.00%   81.07%   +2.07%     
==========================================
  Files        1352     1360       +8     
  Lines      189537   190776    +1239     
==========================================
+ Hits       149739   154676    +4937     
+ Misses      34341    30621    -3720     
- Partials     5457     5479      +22     
Components Coverage Δ
Client 72.33% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.25% <100.00%> (+2.46%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/impl.go 84.64% <100.00%> (+6.45%) ⬆️

... and 253 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 25, 2024

@Reidddddd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@Reidddddd
Copy link
Contributor Author

rerun go-sdk

@Reidddddd
Copy link
Contributor Author

rerun cpp-unit-test

@Reidddddd
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@Reidddddd
Copy link
Contributor Author

/run-cpu-e2e

@Reidddddd
Copy link
Contributor Author

Reidddddd commented Nov 28, 2024

failed with [pytest : test] [2024-11-25 08:15:22 - ERROR - pymilvus.decorators]: RPC error: [search], <MilvusException: (code=65535, message=not allowed to retrieve raw data of field text_sparse_emb)>, <Time:{'RPC start': '2024-11-25 08:15:22.913176', 'RPC error': '2024-11-25 08:15:22.915668'}> (decorators.py:140)

seems not relevant

@Reidddddd
Copy link
Contributor Author

Hi @xiaofan-luan , can please take a look, a very simple patch

@xiaofan-luan
Copy link
Collaborator

/run-cpu-e2e

@xiaofan-luan
Copy link
Collaborator

@Reidddddd
we need an issue and description for this pr to merge

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Reidddddd, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 2, 2024

@Reidddddd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@Reidddddd
Copy link
Contributor Author

@Reidddddd we need an issue and description for this pr to merge

Issue is here: #37982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. do-not-merge/missing-related-issue kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants