Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grant ManualCompact api doesn't work #38096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #38086
cause ManualCompact api pass collection id in request, but RBAC requires to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in request.

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/S Denotes a PR that changes 10-29 lines. labels Nov 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (1084349) to head (09db2fa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/impl.go 12.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38096   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files        1369     1369           
  Lines      190968   190981   +13     
=======================================
+ Hits       154819   154840   +21     
+ Misses      30659    30655    -4     
+ Partials     5490     5486    -4     
Components Coverage Δ
Client 73.67% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.21% <46.15%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/database_interceptor.go 96.16% <100.00%> (+0.07%) ⬆️
internal/proxy/impl.go 84.54% <12.50%> (-0.10%) ⬇️

... and 25 files with indirect coverage changes

cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <[email protected]>
Copy link
Contributor

mergify bot commented Nov 29, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 29, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 30, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants