-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: grant ManualCompact api doesn't work #38096
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38096 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 1369 1369
Lines 190968 190981 +13
=======================================
+ Hits 154819 154840 +21
+ Misses 30659 30655 -4
+ Partials 5490 5486 -4
|
cause ManualCompact api pass collection id in request, but RBAC requires to check collection name, so grant ManualCompact api doesn't work. This PR refine the ManualCompact api to accpet collection name in request. Signed-off-by: Wei Liu <[email protected]>
12fd705
to
09db2fa
Compare
@weiliu1031 go-sdk check failed, comment |
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
rerun go-sdk |
@weiliu1031 E2e jenkins job failed, comment |
issue: #38086
cause ManualCompact api pass collection id in request, but RBAC requires to check collection name, so grant ManualCompact api doesn't work.
This PR refine the ManualCompact api to accpet collection name in request.