-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Remove unnecessary segment validation on worker node #38108
base: master
Are you sure you want to change the base?
enhance: Remove unnecessary segment validation on worker node #38108
Conversation
This PR remove unnecessary segment validation on worker node, also refine the segment's func call on `pin and unpin`. Signed-off-by: Wei Liu <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@weiliu1031 go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38108 +/- ##
===========================================
+ Coverage 68.87% 81.05% +12.18%
===========================================
Files 289 1368 +1079
Lines 25484 190912 +165428
===========================================
+ Hits 17551 154749 +137198
- Misses 7933 30671 +22738
- Partials 0 5492 +5492
|
issue: #38109
This PR remove unnecessary segment validation on worker node, also refine the segment's func call on
pin and unpin
.