Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove unnecessary segment validation on worker node #38108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Nov 29, 2024

issue: #38109
This PR remove unnecessary segment validation on worker node, also refine the segment's func call on pin and unpin.

This PR remove unnecessary segment validation on worker node, also
refine the segment's func call on `pin and unpin`.

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Nov 29, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 80.64516% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (1084349) to head (460373e).

Files with missing lines Patch % Lines
internal/querynodev2/segments/search.go 75.67% 8 Missing and 1 partial ⚠️
internal/querynodev2/segments/statistics.go 45.45% 6 Missing ⚠️
internal/querynodev2/segments/retrieve.go 81.81% 2 Missing ⚠️
internal/querynodev2/handlers.go 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38108       +/-   ##
===========================================
+ Coverage   68.87%   81.05%   +12.18%     
===========================================
  Files         289     1368     +1079     
  Lines       25484   190912   +165428     
===========================================
+ Hits        17551   154749   +137198     
- Misses       7933    30671    +22738     
- Partials        0     5492     +5492     
Components Coverage Δ
Client 73.67% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.19% <80.64%> (∅)
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 87.28% <100.00%> (ø)
internal/querynodev2/tasks/query_stream_task.go 78.72% <100.00%> (ø)
internal/querynodev2/tasks/query_task.go 90.09% <100.00%> (ø)
internal/querynodev2/tasks/search_task.go 84.49% <100.00%> (ø)
internal/querynodev2/handlers.go 77.07% <75.00%> (ø)
internal/querynodev2/segments/retrieve.go 82.53% <81.81%> (ø)
internal/querynodev2/segments/statistics.go 71.79% <45.45%> (ø)
internal/querynodev2/segments/search.go 65.95% <75.67%> (ø)

... and 1071 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants