-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix grant/revoke v2 meta and unclear error messages #38110
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shaoting-huang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@shaoting-huang E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38110 +/- ##
===========================================
+ Coverage 68.87% 81.08% +12.21%
===========================================
Files 289 1369 +1080
Lines 25484 190978 +165494
===========================================
+ Hits 17551 154863 +137312
- Misses 7933 30634 +22701
- Partials 0 5481 +5481
|
/run-cpu-e2e |
@shaoting-huang E2e jenkins job failed, comment |
/lgtm |
/run-cpu-e2e |
@shaoting-huang E2e jenkins job failed, comment |
/run-cpu-e2e |
@shaoting-huang E2e jenkins job failed, comment |
Signed-off-by: shaoting-huang <[email protected]>
11033a1
to
2fac18c
Compare
New changes are detected. LGTM label has been removed. |
@shaoting-huang E2e jenkins job failed, comment |
@shaoting-huang go-sdk check failed, comment |
/run-cpu-e2e |
rerun go-sdk |
@shaoting-huang go-sdk check failed, comment |
related issue: #37031
fixed issues:
#37974: better error messages for grant v2 interface
#37903: fix meta built-in privilege group object name
#37843: better error messages for custom privilege group interface
#38002: fix built-in privilege group meta to pass proxy interceptor check
#38008: fix revoke v2 to support revoking v1 granted privileges