Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Handle rust error in c++ #38113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Nov 29, 2024

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Signed-off-by: sunby <[email protected]>
Copy link
Contributor

mergify bot commented Nov 29, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (c6dcef7) to head (b397df9).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38113      +/-   ##
==========================================
- Coverage   82.89%   81.06%   -1.83%     
==========================================
  Files        1079     1369     +290     
  Lines      165507   190971   +25464     
==========================================
+ Hits       137189   154817   +17628     
- Misses      22807    30658    +7851     
+ Partials     5511     5496      -15     
Components Coverage Δ
Client 73.67% <ø> (+1.07%) ⬆️
Core 68.87% <ø> (∅)
Go 83.20% <ø> (+0.02%) ⬆️

see 322 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 30, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants