Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add collection id to search request count metrics (#38069) #38145

Closed

Conversation

weiliu1031
Copy link
Contributor

pr: #38069

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (fcbed3a) to head (909bf2d).

Files with missing lines Patch % Lines
internal/querynodev2/handlers.go 75.00% 2 Missing ⚠️
internal/querynodev2/services.go 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38145       +/-   ##
===========================================
+ Coverage   68.87%   81.03%   +12.15%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190678   +165197     
===========================================
+ Hits        17551   154516   +136965     
- Misses       7930    30665    +22735     
- Partials        0     5497     +5497     
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.20% <82.35%> (∅)
Files with missing lines Coverage Δ
pkg/metrics/querynode_metrics.go 100.00% <ø> (ø)
internal/querynodev2/services.go 87.39% <88.88%> (ø)
internal/querynodev2/handlers.go 77.19% <75.00%> (ø)

... and 1068 files with indirect coverage changes

@weiliu1031 weiliu1031 closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants