Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable integration test caused by paramtable.GetNodeID #37910

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #37908
pr: #37909
cause paramtable is global single instance, which cause paramtable.GetNodeID may return wrong server id in integration test.

This PR use node.GetNodeID to replace paramtable.GetNodeID

cause paramtable is global single instance, which cause
paramtable.GetNodeID may return wrong server id in integration test.

This PR use node.GetNodeID to replace paramtable.GetNodeID

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 21, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Nov 21, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (0bd2617) to head (6436e14).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querynodev2/services.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37910      +/-   ##
==========================================
- Coverage   80.63%   80.59%   -0.04%     
==========================================
  Files        1069     1069              
  Lines      166978   166979       +1     
==========================================
- Hits       134643   134579      -64     
- Misses      27930    27979      +49     
- Partials     4405     4421      +16     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator_data.go 88.47% <ø> (-0.09%) ⬇️
internal/querynodev2/services.go 86.54% <33.33%> (-0.65%) ⬇️

... and 34 files with indirect coverage changes

---- 🚨 Try these New Features:

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 22, 2024
@sre-ci-robot sre-ci-robot merged commit e63a2f3 into milvus-io:2.4 Nov 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants