-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Knowledge Base Retrieval Params & Preprocessing #61
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
from typing import Any, Dict, List, Literal, Optional | ||
|
||
from pydantic import BaseModel, Field, model_validator | ||
|
||
|
||
DEFAULT_LLM_MODEL = 'gpt-4o' | ||
DEFAULT_LLM_MODEL_PROVIDER = 'openai' | ||
|
||
|
||
class TextChunkingConfig(BaseModel): | ||
'''Configuration for chunking text content before they are inserted into a knowledge base''' | ||
separators: List[str] = Field( | ||
default=['\n\n', '\n', ' ', ''], | ||
description='List of separators to use for splitting text, in order of priority' | ||
) | ||
chunk_size: int = Field( | ||
default=1000, | ||
description='The target size of each text chunk', | ||
gt=0 | ||
) | ||
chunk_overlap: int = Field( | ||
default=200, | ||
description='The number of characters to overlap between chunks', | ||
ge=0 | ||
) | ||
|
||
|
||
class LLMConfig(BaseModel): | ||
model_name: str = Field(default=DEFAULT_LLM_MODEL, description='LLM model to use for context generation') | ||
provider: str = Field(default=DEFAULT_LLM_MODEL_PROVIDER, description='LLM model provider to use for context generation') | ||
params: Dict[str, Any] = Field(default={}, description='Additional parameters to pass in when initializing the LLM') | ||
|
||
|
||
class ContextualConfig(BaseModel): | ||
'''Configuration specific to contextual preprocessing''' | ||
llm_config: LLMConfig = Field( | ||
default=LLMConfig(), | ||
description='LLM configuration to use for context generation' | ||
) | ||
context_template: Optional[str] = Field( | ||
default=None, | ||
description='Custom template for context generation' | ||
) | ||
chunk_size: int = Field( | ||
default=1000, | ||
description='The target size of each text chunk', | ||
gt=0 | ||
) | ||
chunk_overlap: int = Field( | ||
default=200, | ||
description='The number of characters to overlap between chunks', | ||
ge=0 | ||
) | ||
|
||
|
||
class PreprocessingConfig(BaseModel): | ||
'''Complete preprocessing configuration''' | ||
type: Literal['contextual', 'text_chunking'] = Field( | ||
default='text_chunking', | ||
description='Type of preprocessing to apply' | ||
) | ||
contextual_config: Optional[ContextualConfig] = Field( | ||
default=None, | ||
description='Configuration for contextual preprocessing' | ||
) | ||
text_chunking_config: Optional[TextChunkingConfig] = Field( | ||
default=None, | ||
description='Configuration for text chunking preprocessing' | ||
) | ||
|
||
@model_validator(mode='after') | ||
def validate_config_presence(self) -> 'PreprocessingConfig': | ||
'''Ensure the appropriate config is present for the chosen type''' | ||
if self.type == 'contextual' and not self.contextual_config: | ||
self.contextual_config = ContextualConfig() | ||
if self.type == 'text_chunking' and not self.text_chunking_config: | ||
self.text_chunking_config = TextChunkingConfig() | ||
return self |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 Nice