Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error inspection: "Invoker has the same method name as target method" #2342

Open
Octol1ttle opened this issue Aug 1, 2024 · 1 comment

Comments

@Octol1ttle
Copy link
Contributor

Minecraft Development for IntelliJ plugin version

2024.1-1.8.0

Description of the feature request

In Mixins, if the invoker method has the same name as the target method, then non-obfuscated environments will encounter a StackOverflowError upon calling the method. Without a proficient understanding of how Mixin merges @Mixin classes with their targets, it may be difficult for developers to debug this. Having an inspection with an Error severity would help them notice this issue before it causes problems

@Earthcomputer
Copy link
Member

I would propose for this to be a warning, to match the warning level of making a method which does nothing except call itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants