Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook JS SDK loaded but not used? #27

Open
pbinkley opened this issue Dec 16, 2020 · 0 comments
Open

Facebook JS SDK loaded but not used? #27

pbinkley opened this issue Dec 16, 2020 · 0 comments

Comments

@pbinkley
Copy link
Member

The Facebook JS SDK is loaded at

ed/_layouts/default.html

Lines 70 to 86 in c62010e

<!-- Facebook SDK for JavaScript -->
<script>
window.fbAsyncInit = function() {
FB.init({
appId : '589495744558280',
xfbml : true,
version : 'v2.6'
});
};
(function(d, s, id){
var js, fjs = d.getElementsByTagName(s)[0];
if (d.getElementById(id)) {return;}
js = d.createElement(s); js.id = id;
js.src = "//connect.facebook.net/en_US/sdk.js";
fjs.parentNode.insertBefore(js, fjs);
}(document, 'script', 'facebook-jssdk'));
, but as far as I can tell it's only referenced in some meta tags
<meta property="fb:admins" content="elotroalex" />
(though I'm not sure whether those are related to the sdk or general Facebook tagging). The wiki mentions moving its config into _config.yml https://github.com/minicomp/ed/wiki/Version-Roadmap#_configyml , but there's nothing there in the out-of-the-box config.

Is it safe to remove it? Or could its inclusion be made conditional on having the config present in _config.yml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant