Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images are generated with restrictive permissions #7

Closed
pbinkley opened this issue Jun 5, 2020 · 1 comment · May be fixed by #8
Closed

Images are generated with restrictive permissions #7

pbinkley opened this issue Jun 5, 2020 · 1 comment · May be fixed by #8

Comments

@pbinkley
Copy link
Member

pbinkley commented Jun 5, 2020

On Linux, at least, the generated images have only user rw permissions. When copied to a space where the web server does not run as the owning user, the images cannot be served.

I'll put in a pr over the weekend to generate them with ugo+r permissions.
@pbinkley
Copy link
Member Author

pbinkley commented Jun 10, 2020 •
edited
Loading

I have a little fix, which I've only tested on Linux. I'll test it on Windows before I put in a pull request. It sets the permissions on variant images to match those of the source image.

This seems to be a long-standing behavior of MiniMagick (see this issue). It seems to me that matching the permissions of the source image is a better match to likely user expectations (certainly mine) that giving them -rw-------.

@pbinkley pbinkley mentioned this issue Jun 13, 2020
Open
@mnyrop mnyrop closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set permissions on variant images to match source image pbinkley/wax_iiif
2 participants
@pbinkley @mnyrop