Add support for zombie options #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Jun 23, 2017
src/NodeJS/Server.php
Outdated
| */ | ||
| public function setOptions($options) | ||
| { | ||
| if (!is_array($options)) { |
src/NodeJS/Server.php
Outdated
| @@ -46,6 +46,11 @@ | |||
| protected $threshold; | |||
|
|
|||
| /** | |||
| * @var array | |||
| */ | |||
| protected $options; | |||
There was a problem hiding this comment.
please use private visibility for the new property (as it has both a getter and a setter which are public, there is no benefit making this accessible through inheritance, and protected stuff makes it harder to handle backward compatibility)
There was a problem hiding this comment.
@stof I tried to follow what's already there and all the other properties are protected while having setters and getters.
There was a problem hiding this comment.
@berliner , please make this change. I guess that's last thing before this PR is merged.
There was a problem hiding this comment.
@aik099 Done, though I still feel that this doesn't belong into this PR.
aik099
approved these changes
Jun 24, 2017
|
Merging, thanks @berliner . |
This was referenced Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #154.
This PR allows to specify zombie options as an array argument to the server constructor.
I have applied more or less the same logic as for the threshold argument.
Tests have been updated/added too.
I didn't update the README, but instead would issue a PR against the docs repo once this PR here has been approved.
The associated PR for Behat/MinkExtension is Behat/MinkExtension#284