Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System mouse
Fixing mouse selection so that SysMouse isn't selected for all mice
RawInput SysMouse is always selected for both mice, making a 2p game impossible. The acquire function so that device 0 can never be detected, until a more proper fix can be made. I think it's unnecessary to pick up the sysmouse with init_raw_mouse() since I don't see why you would use it, but if you want to pick it up you'll have to fix get_guncon_hid_device()
Sync cursor with system cursor
Fixes to SnapCursor() and SetCursorPos() so that both mice can move the cursor. It's hard to calibrate the guncon otherwise.
The SnapCursor() and SetCursorPos() section in PADpoll_guncon is fixed so that both mice can move the cursor. It's hard to calibrate the guncon otherwise
Off screen shot
The off screen shots function set the shot position to (0,0) when the cursor is at the edges, i.e. when aiming is as far out as possible because
Guncon calibration profiles
I've attached guncon calibration profiles for TC2 and TC3 that are perfect and final since they are set with guncon calibration values hacked to zero with the attached cheats.
Unfortunately the calibration that is accurate in single player mode in TC3 is not accurate in split-screen mode, the split screen mode therefore has separate calibration values if you want the most accurate calibration. The y-axis calibration isn't perfect in TC3 split-screen since the y-axis values aren't treated consistent by the game, the values are set so that the aim is too high and too low as little as possible. If you want to play TC2 and TC3 split screen at all you have to use this patch mirror/pcsx2#1
The guncon calibration screen is only a nuisance that obstruct accurate calibration, but i couldn't find a patch to skip it without disabling the guncons too.
In Time Crisis 3 NTSC (7290669C) "patch=1,EE,128780,word,03e00008" skips it, with disabled guncons, and in Time Crisis 2 NTSC (D5D560FF) "patch=1,EE,0020fec0,word,03e00008" has the same effect, so for now the calibration screen must be clicked past, but the calibration values should be fixed to zero with the patch
Unfortunately for guncon2 the x calibration is stored in the plugin so they can't be patched with .pnatch files, but i've attached ArtMoney tables with pointers to the plugin below, notice that they are revision specific as there are no fixed pointers between revisions. Running ArtMoney is some additional work, but it's the only way when the .pnatch files can't do it, if you want accurate calibration that doesn't change from game to game.
Summary
These changes are located at #1
Files