-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSRV Policy #289
Comments
For now I'm postponing a decision here. I have restored the intended MSRV policy by dropping |
I don't think we depend on |
I think the current state is pretty reasonable:
So I'd propose a policy of remaining something like 2-3 years behind the latest rust for |
I wanted to originally support old Rust versions for as long as I can since insta is a testing tool and as a user you never want to be in a situation where you cannot test your own crate to your own preferred version ranges because your test tool moves you up.
Unfortunately the world is moving up around insta right now:
once_cell
, which moved up to 1.56: Minimum Rust Version matklad/once_cell#201: potential workaround is to ditchonce_cell
similar
usesbstr
which in the 1.x release train moved up to 1.60. This is a bit of a weird situation since this is my own crate but there are users who would like the new version to avoid duplicates: Updatebstr
to 1.x similar#40console
usesonce_cell
which indirectly now moved to 1.56: Drop once_cell / new MSRV Policy console-rs/console#134toml
is moving up to 1.60 but they are open to making this a semver bump: MSRV policy toml-rs/toml#346A few other things already moved up, some of which we dropped in the process (see #214)
I have not yet decided what I want to do here, but one way is to drop
once_cell
for now and not to upgrade insimilar
to postpone this issue for a while. Potentially the discussion in the community settles by then. It seems like the community is abandoning supporting old rustc versions in general (see rust-lang/libs-team#72).The text was updated successfully, but these errors were encountered: