Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] integrate romkatv/gitstatus #6

Open
CircleCode opened this issue May 22, 2020 · 1 comment
Open

[feature request] integrate romkatv/gitstatus #6

CircleCode opened this issue May 22, 2020 · 1 comment

Comments

@CircleCode
Copy link

Hi, would you consider integrating with romkatv/gitstatus?
this would improve git module performance, and benefit to #5 (since gitstatus has its own cache) without requiring further work

@mjrafferty
Copy link
Owner

It's certainly possible to integrate that as a new module, but I have no intention of replacing the existing git module with it. If you or someone else wants to write a module for it I'd be happy to consider including it in the repo, or you could just use it for personal use. The module should be pretty simple to write for someone familiar with gitstatus.

That said, it's unlikely to help with #5. The issue with that isn't a lack of cache, it's a lack of properly formatted cache. The scrollback theme can have an entirely different configuration than the main theme with different colors, value representations, and items. For a simpler module with no configuration available it would be extremely easy to pull that from the existing cache, but for one with a customizable output we would need to rebuild the entire output using the new configuration.

It's not impossible to do and probably not all that difficult to implement now that I've put some thought into it. If there's enough demand for it I think I can get it added in. It's not something I care about so it wasn't a thing I thought to implement during development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants