Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove syn dependency #124

Closed
mmastrac opened this issue Feb 5, 2021 · 3 comments · Fixed by #311
Closed

Remove syn dependency #124

mmastrac opened this issue Feb 5, 2021 · 3 comments · Fixed by #311
Labels
1.0 enhancement New feature or request help wanted Extra attention is needed

Comments

@mmastrac
Copy link
Owner

mmastrac commented Feb 5, 2021

This adds some extra compile time that we really don't need.

@mmastrac mmastrac added enhancement New feature or request help wanted Extra attention is needed labels Aug 31, 2021
@mmastrac mmastrac mentioned this issue Sep 1, 2021
3 tasks
@mmastrac mmastrac added the 1.0 label Sep 1, 2021
@mitsuhiko
Copy link

mitsuhiko commented Jan 22, 2022

I did some experiments with ctor stuff recently and ended up implementing just the #[ctor] attribute here without using syn. Feel free to use this: https://crates.io/crates/small_ctor

That version also makes unsafe mandatory (also proposed by #159).

@mmastrac
Copy link
Owner Author

@mitsuhiko Excellent! If you'd like, I'm happy to pull this code into the repo. We can add you as a contributor as well.

@mitsuhiko
Copy link

I'm happy to contribute. I mostly ended up with having this separate for now because I didn't feel enough motivation to touch all the other parts of it yet (static, dtor) which I do not need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants