Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/thirdparty: add lukechampine/blake3 #164

Closed
mmcloughlin opened this issue Dec 31, 2020 · 5 comments · Fixed by #231
Closed

tests/thirdparty: add lukechampine/blake3 #164

mmcloughlin opened this issue Dec 31, 2020 · 5 comments · Fixed by #231
Labels
testing Tests and supporting infrastructure

Comments

@mmcloughlin
Copy link
Owner

Add lukechampine/blake3 to the third-party test suite.

Perhaps wait until #20 has been resolved, and the blake3 code has been adapted to use it?

cc @lukechampine
@mmcloughlin mmcloughlin added the testing Tests and supporting infrastructure label Dec 31, 2020
@lukechampine
Copy link
Contributor

I don't see much harm in adding it now, since (I'm fairly sure) the filenames and structure of the code won't be affected by #20.

tbh I'm a little embarrassed by that code -- it generates way more asm than it should. Maybe this will spur me to clean it up a bit 😅

@mmcloughlin
Copy link
Owner Author

mmcloughlin commented Dec 31, 2020 •
edited
Loading

My hesitation is because I think your code will break when #163 lands? I think some of your manually defined AVX-512 instructions will cause redeclaration errors.

@lukechampine
Copy link
Contributor

ah, got it. Alright, let's wait then.

@lukechampine
Copy link
Contributor

Updated! :)
https://github.com/lukechampine/blake3/releases/tag/v1.1.7

@mmcloughlin mmcloughlin mentioned this issue Nov 13, 2021
Merged
@mmcloughlin
Copy link
Owner Author

Awesome! Just put up #231

Consider making avo a submodule, so you can explicitly depend on an avo version.

mmcloughlin added a commit that referenced this issue Nov 13, 2021
@mmcloughlin
tests/thirdparty: add lukechampine/blake3 (#231)
68350e4 
Fixes #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Tests and supporting infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/thirdparty: add lukechampine/blake3 mmcloughlin/avo
2 participants
@lukechampine @mmcloughlin