Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Fields to RawEEGLAB and EpochsEEGLAB Classes #12772

Closed
MohammadMow opened this issue Aug 2, 2024 · 3 comments
Closed

Add Missing Fields to RawEEGLAB and EpochsEEGLAB Classes #12772

MohammadMow opened this issue Aug 2, 2024 · 3 comments
Labels

Comments

@MohammadMow
Copy link

Describe the new feature or enhancement

The current implementation of the RawEEGLAB and EpochsEEGLAB classes in the MNE library does not load all available fields from EEGLAB .set files. Important fields such as 'icaact', 'icawinv', and several others are missing. This feature request aims to extend the functionality of these classes to include all possible fields present in EEGLAB .set files.

The following fields should be added to both RawEEGLAB and EpochsEEGLAB classes:

  • icaact
  • icawinv
  • icasphere
  • icaweights
  • icachansind
  • chanlocs
  • urchanlocs
  • chaninfo
  • ref
  • event
  • urevent
  • eventdescription
  • epoch
  • epochdescription
  • reject
  • stats
  • specdata
  • specicaact
  • splinefile
  • icasplinefile
  • dipfit
  • history
  • saved
  • etc
  • run
  • roi
  • datfile

Describe your proposed implementation

Using Composition and Create a DataContainerEEGLAB Class

I think Composition is a good solution. This class will be responsible for storing and managing all the fields from the EEGLAB .set file. The class will be initialized with a Bunch object containing EEG data and will extract and store all possible fields. Then RawEEGLAB and EpochsEEGLAB classes will have a data_container field.

Describe possible alternatives

Multiple Inheritance

I think it is better not to use multiple inheritance because it may cause problems such as having the same name of the methods, etc.

Additional context

No response

@MohammadMow MohammadMow added the ENH label Aug 2, 2024
Copy link

welcome bot commented Aug 2, 2024

Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴

@mscheltienne
Copy link
Member

The ICA fields are read by this function in an ICA object: https://mne.tools/dev/generated/mne.preprocessing.read_ica_eeglab.html
Or is something else missing?

@drammock
Copy link
Member

drammock commented Aug 8, 2024

closing as not planned; see discussion in #12773 (comment)

@drammock drammock closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants