Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add that minimum number of channels for defining cluster is 0 in documentation #13008

Open
kerrencasper opened this issue Dec 5, 2024 · 2 comments
Labels

Comments

@kerrencasper
Copy link

Proposed documentation enhancement

In mne.stats.permutation_cluster_test there is no way of defining the minimum number of neighbouring points that defines a cluster. This is a major error in the code, which makes the code invalid. This has been discussed by many of the developers for years, but nothing has been done (see issue #10604, #10604). Most people 1) don't know why this is a problem; 2) blindly trust the function. The least you can do if you are not ready to change it is to add to the documentation that this is a shortcoming of the function and that it should not be used until it has been solved. To exclude clusters with less than n number of channels (as has been discussed in the above-linked thread) is not a valid way forward as the t-values for these clusters have already been part of the t-distribution for defining the threshold for what can be considered significant.

Copy link

welcome bot commented Dec 5, 2024

Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴

@larsoner
Copy link
Member

larsoner commented Dec 5, 2024

Hmm... I think our minimum number is effectively 1, which should make it so things are valid, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants