-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes make_scalp_surfaces #13024
Draft
vferat
wants to merge
22
commits into
mne-tools:main
Choose a base branch
from
vferat:dev-headsurface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fixes make_scalp_surfaces #13024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into dev-headsurface
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into dev-headsurface
for more information, see https://pre-commit.ci
…into dev-headsurface
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into dev-headsurface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #13014.
What does this implement/fix?
Updates
make_scalp_surfaces
to force regeneratingseghead.mgz
,lh.seghead
and{subject}-head-{{}}.fif
ifoverwrite
is set toTrue
. Will raise an OSError if eitherseghead.mgz
,lh.seghead
and{subject}-head-{{}}.fif
exists andoverwrite
is set toFalse
Additional information
There are some edgy cases when mixing
overwrite
andno_decimate
which can lead to{subject}-head-medium.fif
/{subject}-head-sparse.fif
to be untouched whileseghead.mgz
,lh.seghead
and{subject}-head-dense.fif
are regenerated.I tried to handle theses cases by always deleting
{subject}-head-medium.fif
/{subject}-head-sparse.fif
ifoverwrite=True
(even ifno_decimate=True
) and by raising and specific error ifoverwrite=False
,no_decimate=True
but{subject}-head-medium.fif
/{subject}-head-sparse.fif
exist.