Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes make_scalp_surfaces #13024

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

Fixes make_scalp_surfaces #13024

wants to merge 22 commits into from

Conversation

vferat
Copy link
Contributor

@vferat vferat commented Dec 12, 2024

Reference issue (if any)

Fixes #13014.

What does this implement/fix?

Updates make_scalp_surfaces to force regenerating seghead.mgz ,lh.seghead and {subject}-head-{{}}.fif if overwrite is set to True. Will raise an OSError if either seghead.mgz ,lh.seghead and {subject}-head-{{}}.fif exists and overwrite is set to False

Additional information

There are some edgy cases when mixing overwrite and no_decimate which can lead to {subject}-head-medium.fif / {subject}-head-sparse.fif to be untouched while seghead.mgz ,lh.seghead and {subject}-head-dense.fif are regenerated.

I tried to handle theses cases by always deleting {subject}-head-medium.fif / {subject}-head-sparse.fif if overwrite=True (even if no_decimate=True) and by raising and specific error if overwrite=False , no_decimate=True but {subject}-head-medium.fif / {subject}-head-sparse.fif exist.

@larsoner larsoner added this to the 1.10 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mne make_scalp_surfaces does not recompute mkheadsurf
2 participants