Skip to content

Commit

Permalink
chore: update test workflow for PR
Browse files Browse the repository at this point in the history
  • Loading branch information
mob-sakai committed Nov 23, 2024
1 parent 40df577 commit 2430656
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 15 deletions.
42 changes: 35 additions & 7 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,37 @@
---
name: Pull Request
about: Create a pull request
title: ''
assignees: mob-sakai

---
# Pull Request Template

**NOTE: Create a pull request to merge into `develop` branch**
## Description

- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context.
- List any dependencies that are required for this change.

Fixes #{issue_number}

## Type of change

Please write the commit message in the format corresponding to the change type.
Please see [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for more information.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Update documentations
- [ ] Others (refactoring, style changes, etc.)

## Test environment

- Platform: [e.g. Editor(Windows/Mac), Standalone(Windows/Mac), iOS, Android, WebGL]
- Unity version: [e.g. 2022.2.0f1]
- Build options: [e.g. IL2CPP, .Net 4.x, URP/HDRP]

## Checklist

- [ ] This pull request is for merging into the `develop` branch
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have checked my code and corrected any misspellings
36 changes: 28 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# UNITY_EMAIL: Unity user email to login
# UNITY_PASSWORD: Unity user password to login
name: 🧪 Test
run-name: 🧪 Test (${{ github.ref_name }})
run-name: 🧪 Test (${{ github.event.pull_request.title || github.ref_name }})

env:
# MINIMUM_VERSION: The minimum version of Unity.
Expand All @@ -24,12 +24,15 @@ on:
- develop-preview
tags:
- "!*"
paths-ignore:
- "*.md"
pull_request:
paths:
- "!**.md"
pull_request_target:
types:
- opened
- reopened
- synchronize
paths:
- "!**.md"

jobs:
setup:
Expand All @@ -56,13 +59,11 @@ jobs:
test:
name: 🧪 Run tests
runs-on: ubuntu-latest
env:
UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}
permissions:
checks: write
contents: read
pull-requests: write
secrets: read
needs: setup
strategy:
fail-fast: false
Expand All @@ -71,8 +72,23 @@ jobs:
unityVersion: ${{ fromJson(needs.setup.outputs.unityVersions) }}
steps:
- name: 🚚 Checkout
if: github.event_name == 'push'
uses: actions/checkout@v4

- name: 🚚 Checkout pull request (pull_request_target)
if: github.event_name == 'pull_request_target'
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0

- name: 🚚 Marge pull request (pull_request_target)
if: github.event_name == 'pull_request_target'
run: |
git config user.name "GitHub Actions"
git config user.email "[email protected]"
git merge origin/${{ github.event.pull_request.base.ref }} --no-edit
- name: 📥 Cache library
uses: actions/cache@v4
with:
Expand All @@ -90,6 +106,10 @@ jobs:
targetPlatform: StandaloneLinux64
allowDirtyBuild: true
customParameters: -nographics
env:
UNITY_EMAIL: ${{ secrets.UNITY_EMAIL }}
UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }}
UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}

# - name: 🧪 Run tests
# uses: game-ci/unity-test-runner@v4
Expand Down

0 comments on commit 2430656

Please sign in to comment.