Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog configuration should be fixed #18

Open
adpaco-aws opened this issue Aug 17, 2022 · 2 comments
Open

Blog configuration should be fixed #18

adpaco-aws opened this issue Aug 17, 2022 · 2 comments

Comments

@adpaco-aws
Copy link
Contributor

The publication of the first blog post forced us to make some quick changes to the configuration (see #6 and #7). But this configuration is not the right one, since links to other posts and images still need to be pasted "as is" (when we could be using the more elegant syntax to include references). This also means that testing is not 100% reliable, and deployments can fail when the tested version was working.

@adpaco-aws adpaco-aws self-assigned this Aug 17, 2022
@celinval
Copy link

From the little research I've done, this is a github pages issue. Links generated using absolute syntax do not include the name of the repository, so it's incorrectly generated.

Let's say we have:

![My image](/assets/my_image.png)

When we build the page, the link will actually map to:

http://[user|org].github.io/assets/my_image.png

instead of

http://[user|org].github.io/[repo]/assets/my_image.png

So there's two options that would be testable in a PR level (but that requires the fork to have the same repository name -- i.e.: kani-verifier-blog):

  1. Use absolute path but include the name of the repository:
![My image](/kani-verifier-blog/assets/my_image.png)
  1. Use the embedded HTML version with a reference to the baseurl:
<img src="/{{site.baseurl}}/assets/my_image.png" alt="My image" />

@celinval
Copy link

Note that both solutions will not render in the markdown github preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants