Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

add open in app button to mod & modpack project pages #1731

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

evergales
Copy link

I noticed that theseus takes 'modrinth://' deeplinks for mods and modpacks

I thought it would be nice to add an 'open in app' button to those pages
because as far as I know there is currently no way (other than pasting code into console)
to use unlisted mods or modpacks in the launcher
and this could be a convenient way to make that a bit better
along with just being a nice qol feature

the-thing.mp4

I wasn't sure about making a thread for this in discord but can if needed!

@Prospector
Copy link
Member

We had planned on implementing it a different way, but I think doing it this way would be great for now!

One thing is, this should work for anything except for a mod that only supports plugin loaders I believe, since the Modrinth App supports everything but plugins.

@evergales
Copy link
Author

evergales commented Jun 15, 2024

I think it should be correct now
but #1227 needs to be fixed
and I also think UrlConfirmModal is grabbing old project versions when installing

fixed in: theseus/#1228

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants