From 94db8ce92fd6b78030e89cdf39e996036e865a37 Mon Sep 17 00:00:00 2001
From: Prospector <6166773+Prospector@users.noreply.github.com>
Date: Wed, 6 Dec 2023 15:38:00 -0800
Subject: [PATCH] Add hover menus and fix ProjectCard issue with omitted
 properties (#166)

* Adds hover menus

* Allow ProjectCard props to be omitted

* Bump version
---
 docs/components/popout-menu.md       |  21 +++
 lib/components/base/OverflowMenu.vue |   5 +
 lib/components/base/PopoutMenu.vue   | 200 +++++++++++++++++++--------
 lib/components/base/ProjectCard.vue  |  14 +-
 package.json                         |   2 +-
 5 files changed, 179 insertions(+), 63 deletions(-)

diff --git a/docs/components/popout-menu.md b/docs/components/popout-menu.md
index 31d11de08..cf24f5517 100644
--- a/docs/components/popout-menu.md
+++ b/docs/components/popout-menu.md
@@ -74,3 +74,24 @@
   </template>
 </PopoutMenu>
 ```
+
+# Popout Menu on hover
+<DemoContainer>
+  <PopoutMenu class="btn btn-dropdown-animation" position="bottom" direction="right" allow-hover>
+    Hover me! <DropdownIcon />
+    <template #menu>
+      Menu contents!
+      Menu contents!
+      Menu contents!
+    </template>
+  </PopoutMenu>
+</DemoContainer>
+
+```vue
+<PopoutMenu class="btn" position="bottom" direction="right" allow-hover>
+  Hover me!
+  <template #menu>
+    Menu contents!
+  </template>
+</PopoutMenu>
+```
diff --git a/lib/components/base/OverflowMenu.vue b/lib/components/base/OverflowMenu.vue
index d597b5fa2..82865e5c0 100644
--- a/lib/components/base/OverflowMenu.vue
+++ b/lib/components/base/OverflowMenu.vue
@@ -5,6 +5,7 @@
     :disabled="disabled"
     :position="position"
     :direction="direction"
+    :allow-hover="allowHover"
   >
     <slot></slot>
     <template #menu>
@@ -66,6 +67,10 @@ defineProps({
     type: String,
     default: 'left',
   },
+  allowHover: {
+    type: Boolean,
+    default: false,
+  },
 })
 defineOptions({
   inheritAttrs: false,
diff --git a/lib/components/base/PopoutMenu.vue b/lib/components/base/PopoutMenu.vue
index d979ac083..06ecbe3ce 100644
--- a/lib/components/base/PopoutMenu.vue
+++ b/lib/components/base/PopoutMenu.vue
@@ -1,5 +1,11 @@
 <template>
-  <div ref="dropdown" class="popup-container" tabindex="-1" :aria-expanded="dropdownVisible">
+  <div
+    ref="dropdown"
+    class="popup-container"
+    tabindex="-1"
+    :aria-expanded="dropdownVisible"
+    :class="{ 'allow-hover': allowHover }"
+  >
     <button
       v-bind="$attrs"
       ref="dropdownButton"
@@ -9,6 +15,11 @@
     >
       <slot></slot>
     </button>
+    <div
+      v-if="allowHover"
+      class="hover-bounding-box"
+      :class="`position-${position}-${direction}`"
+    ></div>
     <div
       class="popup-menu"
       :class="`position-${position}-${direction} ${dropdownVisible ? 'visible' : ''}`"
@@ -34,6 +45,10 @@ const props = defineProps({
     type: String,
     default: 'left',
   },
+  allowHover: {
+    type: Boolean,
+    default: false,
+  },
 })
 defineOptions({
   inheritAttrs: false,
@@ -90,6 +105,133 @@ onBeforeUnmount(() => {
 .popup-container {
   position: relative;
 
+  &.allow-hover .hover-bounding-box {
+    position: absolute;
+    inset: 0;
+    border-radius: var(--radius-md);
+    z-index: 1;
+
+    // Debug properties
+    // background-color: red;
+    // opacity: 0.1;
+
+    // Q: Why is this here and also below?
+    // A: For the few browsers that do not yet support :has(), this at least
+    //    makes it mostly functional.
+    &:hover {
+      &.position-bottom-left,
+      &.position-bottom-right {
+        bottom: -1rem;
+      }
+
+      &.position-top-left,
+      &.position-top-right {
+        top: -1rem;
+      }
+
+      &.position-left-up,
+      &.position-left-down {
+        left: -1rem;
+      }
+
+      &.position-right-up,
+      &.position-right-down {
+        right: -1rem;
+      }
+    }
+  }
+
+  &:not(.allow-hover) .popup-menu:not(.visible):not(:focus-within),
+  &.allow-hover:not(:has(.hover-bounding-box:hover)):not(:has(.popup-menu:hover))
+    .popup-menu:not(.visible):not(:focus-within) {
+    pointer-events: none;
+
+    *,
+    ::before,
+    ::after {
+      pointer-events: none;
+    }
+  }
+
+  &.allow-hover:has(.hover-bounding-box:hover),
+  &.allow-hover:has(.popup-menu:hover),
+  :has(.popup-menu.visible),
+  :has(.popup-menu:focus-within) {
+    :deep(.btn-dropdown-animation svg:last-child) {
+      transform: rotate(180deg);
+    }
+
+    .hover-bounding-box {
+      &.position-bottom-left,
+      &.position-bottom-right {
+        bottom: -1rem;
+      }
+
+      &.position-top-left,
+      &.position-top-right {
+        top: -1rem;
+      }
+
+      &.position-left-up,
+      &.position-left-down {
+        left: -1rem;
+      }
+
+      &.position-right-up,
+      &.position-right-down {
+        right: -1rem;
+      }
+    }
+  }
+
+  &.allow-hover .hover-bounding-box:hover + .popup-menu,
+  &.allow-hover .popup-menu:hover,
+  .popup-menu.visible,
+  .popup-menu:focus-within {
+    opacity: 1;
+    scale: 1;
+
+    &.position-bottom-left {
+      top: calc(100% + var(--gap-sm));
+      right: 0;
+    }
+
+    &.position-bottom-right {
+      top: calc(100% + var(--gap-sm));
+      left: 0;
+    }
+
+    &.position-top-left {
+      bottom: calc(100% + var(--gap-sm));
+      right: 0;
+    }
+
+    &.position-top-right {
+      bottom: calc(100% + var(--gap-sm));
+      left: 0;
+    }
+
+    &.position-left-up {
+      bottom: 0rem;
+      right: calc(100% + var(--gap-sm));
+    }
+
+    &.position-left-down {
+      top: 0rem;
+      right: calc(100% + var(--gap-sm));
+    }
+
+    &.position-right-up {
+      bottom: 0rem;
+      left: calc(100% + var(--gap-sm));
+    }
+
+    &.position-right-down {
+      top: 0rem;
+      left: calc(100% + var(--gap-sm));
+    }
+  }
+
   .popup-menu {
     --_animation-offset: -1rem;
     position: absolute;
@@ -149,62 +291,6 @@ onBeforeUnmount(() => {
       left: calc(100% + var(--gap-sm) - 1rem);
     }
 
-    &:not(.visible):not(:focus-within) {
-      pointer-events: none;
-
-      *,
-      ::before,
-      ::after {
-        pointer-events: none;
-      }
-    }
-
-    &.visible,
-    &:focus-within {
-      opacity: 1;
-      scale: 1;
-
-      &.position-bottom-left {
-        top: calc(100% + var(--gap-sm));
-        right: 0;
-      }
-
-      &.position-bottom-right {
-        top: calc(100% + var(--gap-sm));
-        left: 0;
-      }
-
-      &.position-top-left {
-        bottom: calc(100% + var(--gap-sm));
-        right: 0;
-      }
-
-      &.position-top-right {
-        bottom: calc(100% + var(--gap-sm));
-        left: 0;
-      }
-
-      &.position-left-up {
-        bottom: 0rem;
-        right: calc(100% + var(--gap-sm));
-      }
-
-      &.position-left-down {
-        top: 0rem;
-        right: calc(100% + var(--gap-sm));
-      }
-
-      &.position-right-up {
-        bottom: 0rem;
-        left: calc(100% + var(--gap-sm));
-      }
-
-      &.position-right-down {
-        top: 0rem;
-        left: calc(100% + var(--gap-sm));
-      }
-    }
-
     .btn {
       white-space: nowrap;
     }
diff --git a/lib/components/base/ProjectCard.vue b/lib/components/base/ProjectCard.vue
index 2d9a0ebb4..15f986894 100644
--- a/lib/components/base/ProjectCard.vue
+++ b/lib/components/base/ProjectCard.vue
@@ -22,6 +22,7 @@
     <div class="summary">{{ description }}</div>
     <div class="stats">
       <span
+        v-if="downloads"
         v-tooltip="formatMessage(messages.downloads, { count: formatNumber(downloads, false) })"
         class="stat consumes-click"
       >
@@ -29,6 +30,7 @@
         <span class="value">{{ formatNumber(downloads) }}</span>
       </span>
       <span
+        v-if="follows"
         v-tooltip="formatMessage(messages.followers, { count: formatNumber(follows, false) })"
         class="stat consumes-click"
       >
@@ -36,7 +38,7 @@
         <span class="value">{{ formatNumber(follows) }}</span>
       </span>
       <span
-        v-if="showUpdatedDate"
+        v-if="showUpdatedDate && updatedAt"
         v-tooltip="
           formatMessage(messages.updated, {
             date: dayjs(updatedAt).format('MMMM D, YYYY [at] h:mm A'),
@@ -48,7 +50,7 @@
         <span class="value">{{ fromNow(updatedAt) }}</span>
       </span>
       <span
-        v-else
+        v-else-if="createdAt"
         v-tooltip="
           formatMessage(messages.published, {
             date: dayjs(createdAt).format('MMMM D, YYYY [at] h:mm A'),
@@ -60,8 +62,10 @@
         <span class="value">{{ fromNow(createdAt) }}</span>
       </span>
       <div class="tags">
-        <TagIcon />
-        <Categories :type="type" :categories="categories" />
+        <template v-if="categories && categories.length > 0">
+          <TagIcon />
+          <Categories :type="type" :categories="categories" />
+        </template>
       </div>
     </div>
   </article>
@@ -145,7 +149,7 @@ defineProps({
   },
   createdAt: {
     type: String,
-    default: '0000-00-00',
+    default: null,
   },
   updatedAt: {
     type: String,
diff --git a/package.json b/package.json
index 7151f832c..ccf16a1a9 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "omorphia",
   "type": "module",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "files": [
     "dist",
     "locales"