refactor: remote graphite trigger validation #1127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissken
previously approved these changes
Nov 27, 2024
Tetrergeru
reviewed
Nov 28, 2024
Tetrergeru
previously approved these changes
Nov 28, 2024
Co-authored-by: Tetrergeru <[email protected]>
AleksandrMatsko
dismissed stale reviews from Tetrergeru and kissken
via
7e6648f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Before this PR when you tried to create/update trigger on graphite-remote metric source, you received response with status code 503 on any error from graphite.
Now you will get 503 only if graphite returns 401, 502, 503, 504. Otherwise, you will get 400.
Affects endpoints:
PUT /api/triggerPUT /api/trigger/checkPUT /api/trigger/{triggerID}Relates to #1085
Closes #620