-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed memory copy error of virtual table under multiple inheritance #1695
base: main
Are you sure you want to change the base?
Conversation
Can you add a test please? |
I have passed the test in the project of my company. Sorry, the project environment of my company is too big, so it is not suitable to provide the test environment. My company used this in the project, I use it in practice, so it shouldn't be a problem! |
This only tells us that it works for your specific use case and your specific platform / ABI. We have to support multiple ABI's. You may be fixing the issue in one platform and then breaking the rest. You have made a change to this line before without a test and you are doing it again. Your previous PR shouldn't have been merged. |
@hxbb00 We really appreciate your contribution but as @josetr said it would be great if you could add a test. Can you try to recreate this class hierarchy in https://github.com/mono/CppSharp/blob/main/tests/VTables/VTables.h for example? |
Leaving this open for now so we don't forget about it |
No description provided.