Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moodle app should not be automatically exposed on a fixed port #301

Open
NeillM opened this issue Aug 27, 2024 · 0 comments
Open

Moodle app should not be automatically exposed on a fixed port #301

NeillM opened this issue Aug 27, 2024 · 0 comments

Comments

@NeillM
Copy link
Contributor

NeillM commented Aug 27, 2024

When Moodle docker includes the app it automatically exposes a fixed port of 8100 to it on the docker host machine.

This had a couple of issues:

  1. You cannot run multiple instances of moodle-docker that include the app at the same time
  2. If port 8100 is already in use by something else, the other service needs to be shutdown

This is especially problematic on an automatic testing server where you may want to run multiple instances of moodle-docker at the same time.

I think that by default a port to the app should not be exposed to the host machine, and that we should add a new environment variable that controls the host port that exposes the app if it is set.

The existing $MOODLE_DOCKER_APP_PORT controls which moodleapp port is mapped to port 8100 on the host, since it differs depending on if the docker image or the locally compiled version is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant