Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.20 dependency update #1489

Merged
merged 8 commits into from
May 23, 2022
Merged

v0.9.20 dependency update #1489

merged 8 commits into from
May 23, 2022

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented May 10, 2022

What does it do?

Requires audit for changes introduced in:

fn validate_self_contained_inner(
    call: &Call,
    eth_call: &pallet_ethereum::Call<Runtime>,
    signed_info: &<Call as fp_self_contained::SelfContainedCall>::SignedInfo
) -> TransactionValidity {
    .....
    let extra_validation = SignedExtra::validate_unsigned(
        call,
        &call.get_dispatch_info(),
        input_len,
    )?;
    .....
}

With the changes introduced in frontier, pallet-ethereum now does call CheckWeight manually (rest of necessary Extra validation is already taken care on the self contained validation of pallet-ethereum i.e. Nonce).

cc @librelois Please if you can review this last mentioned change and verify that's all that is required validation wise.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@tgmichel tgmichel added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes dependencies Pull requests that update a dependency file labels May 10, 2022
@notlesh notlesh added the D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. label May 10, 2022
@tgmichel tgmichel added D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels May 12, 2022
@tgmichel
Copy link
Contributor Author

@crystalin in the description I linked 2 nimbus PRs that change weights, and might break previous assumptions when accesing the pallets' functionality through precompiles in existing contracts. Should I add breakapi label in this case?

@tgmichel tgmichel marked this pull request as ready for review May 13, 2022 11:17
@@ -19,4 +19,4 @@ moonbeam-rpc-primitives-debug = { path = "../../primitives/rpc/debug" }

# Substrate
codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false }
sp-std = { git = "https://github.com/purestake/substrate", branch = "moonbeam-polkadot-v0.9.19" }
sp-std = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.20" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you avoiding having a moonbeam-polkadot-v0.9.20 branch for substrate? I guess that simplifies things, and we usually don't need to mod the substrate repo... 🤔

@librelois
Copy link
Collaborator

librelois commented May 19, 2022

LGTM

@tgmichel tgmichel merged commit 15b1a1f into master May 23, 2022
@tgmichel tgmichel deleted the moonbeam-polkadot-v0.9.20 branch May 23, 2022 10:44
@tgmichel tgmichel mentioned this pull request May 24, 2022
21 tasks
@crystalin crystalin restored the moonbeam-polkadot-v0.9.20 branch July 7, 2022 18:18
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants