-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.9.20 dependency update #1489
Conversation
# Conflicts: # precompiles/assets-erc20/Cargo.toml
@crystalin in the description I linked 2 nimbus PRs that change weights, and might break previous assumptions when accesing the pallets' functionality through precompiles in existing contracts. Should I add breakapi label in this case? |
@@ -19,4 +19,4 @@ moonbeam-rpc-primitives-debug = { path = "../../primitives/rpc/debug" } | |||
|
|||
# Substrate | |||
codec = { package = "parity-scale-codec", version = "3.0.0", default-features = false } | |||
sp-std = { git = "https://github.com/purestake/substrate", branch = "moonbeam-polkadot-v0.9.19" } | |||
sp-std = { git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.20" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you avoiding having a moonbeam-polkadot-v0.9.20
branch for substrate? I guess that simplifies things, and we usually don't need to mod the substrate repo... 🤔
LGTM |
What does it do?
Requires audit for changes introduced in:
With the changes introduced in frontier,
pallet-ethereum
now does callCheckWeight
manually (rest of necessaryExtra
validation is already taken care on the self contained validation of pallet-ethereum i.e. Nonce).cc @librelois Please if you can review this last mentioned change and verify that's all that is required validation wise.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?