Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

role="listbox" both on suggestionsContainer as well as suggestion ul #701

Open
gaurav5430 opened this issue Jan 4, 2020 · 3 comments · May be fixed by #830
Open

role="listbox" both on suggestionsContainer as well as suggestion ul #701

gaurav5430 opened this issue Jan 4, 2020 · 3 comments · May be fixed by #830
Labels
bug react-autowhatewer

Comments

@gaurav5430
Copy link

gaurav5430 commented Jan 4, 2020 •
edited
Loading

Codepen: https://codepen.io/gaurav5430/pen/rNaYgBe?editors=0010

  1. Focus on the input field
  2. Type c, and wait for suggestions to appear
  3. Look at the rendered html

Observed behaviour: both the suggestions container and the suggestions ul have role="listbox"

Expected behaviour: only the ul should have role="listbox".

Screenshot 2020-01-04 at 11 26 26 PM
@gaurav5430
Copy link
Author

I think this is a regression, it seems to not set the role="listbox" on the container in 9.0.0 , but it does so in the latest version which is 9.4.3

@sundquistm
Copy link

This issue seems to persist from v9 into v10.

@thibaudcolas thibaudcolas mentioned this issue Oct 12, 2021
Open
thibaudcolas added a commit to thibaudcolas/react-autosuggest that referenced this issue Oct 12, 2021
@thibaudcolas
Remove unexpected listbox role from autowhatever items container. Fix m…
fb9d666 
…oroshko#701

This fixes moroshko#701. This can be customised per-project with `renderSuggestionsContainer`, but here is no reason for this container to have a `listbox` role to start with since the list within already does.
@thibaudcolas thibaudcolas linked a pull request Oct 12, 2021 that will close this issue
Open
@thibaudcolas
Copy link
Contributor

This seems like a pretty straightforward fix for an issue affecting all users of the library, so I gave it a shot in #830.

@thibaudcolas thibaudcolas mentioned this issue Oct 13, 2021
Open
@marcusrc marcusrc mentioned this issue May 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug react-autowhatewer
Projects
None yet
Milestone
No milestone
4 participants
@thibaudcolas @aberezkin @gaurav5430 @sundquistm