-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ABI v0.1.0 #22
Comments
v2 here is incompatible with normal v2 so it is really not worth doing. For example, people using current SDKs will fail in a very hard to troubleshoot way. I learned this after opening this issue. |
I think the best approach is to let this repo die and create a compatible implementation directly in mosn/mosn. that way current users can stay taken care of even if they are using revlocked sdks. once they migrate, this repo can be archived. |
I don't disagree about lack of documentation. however, it is hurting mosn to intentionally not be compatible with current SDKs. For example, you can't upgrade tinygo and the version in use is highly flawed. Another choice is to stop using proxy-wasm, because it is incompatible with other proxy-wasm.. since that's the case it is suspicious why use it at all. |
things have changed a lot since #10 also, even if the spec is still very poor. The ecosystem make more tests to deal with this, since mosn is also go it can benefit from it. https://github.com/tetratelabs/proxy-wasm-go-sdk/releases/tag/v0.20.0 Anyway it is your choice, but I think this isn't proxy-wasm anymore it is a dialect of it, and version locked with tooling no-one else can use. I'll close this issue though as it is clear this repository must stay how it is for the foreseeable future. |
the lack of documentation is an important problem, any update on v2 ABI just goes on sdk codes, and we do not have so much time to keep follow with the latest code. |
the documentation problem of proxy-wasm will never change, imho. waiting for that is like waiting for the sun to turn blue. I don't really care, just I was hopeful to be able to help show a nice go server technology able to do well. I can't do it here because you have some constraints that don't match reality.
so, I have nothing I can offer. In any case I don't really like proxy-wasm personally anyway. I just wanted to help show a better proxy story in go 🤷 |
Maybe a bit of a misunderstanding, it's free to make 2.0 compatible with current sdk, we welcome pr. |
ok I have run out of time and working in this codebase is still costly due to the way it is structured and not tested. don't wait for me. It would be much faster to start over. |
Per #10 the current code doesn't properly implement v0.1.0, and worse that version isn't really used or maintained anymore. I suggest focusing effort on maintained ABI. Notably this should also drop "wasi_unstable" for "wasi_snapshot_preview1" as that's what's in use by current compilers.
Until this is dropped implementing another host impl is too much low value work, as it is porting for unused and unmaintable ABI.
@taoyuanyuan @antJack FYI I'm pausing efforts until this is done as I am way over budget already and there's no value proceeding if we have to support an incorrect implementation of an unused ABI version.
The text was updated successfully, but these errors were encountered: