Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misinformation of Reprojection Error. #136

Open
patrickKXMD opened this issue May 29, 2023 · 2 comments
Open

misinformation of Reprojection Error. #136

patrickKXMD opened this issue May 29, 2023 · 2 comments

Comments

@patrickKXMD
Copy link

in getReprojectionError() you will see
ret = std::make_pair(std::sqrt(rotation_err / num_motions), std::sqrt(translation_err / num_motions)); return ret;
which the first value is rotation error and the second is translation error.

But in handeye_control_widget.cpp
reproj_err_text << "Reprojection error:\n" << reproj_err.first << " m, " << reproj_err.second << " rad";
It assumes the first one as translation error.

I don't get it. Is this a mistake?

@CarolinePascal
Copy link

That is definitely a mistake, the function docstring mentions :
* @return Pair of translation and rotation reprojection error in meters and radians, or NaNs on error.
Which is not the case as you pointed out.

Do not hesitate to submit a pull request if you have the time, it's a small fix that should be quickly and easily merged !

@patrickKXMD
Copy link
Author

That is definitely a mistake, the function docstring mentions : * @return Pair of translation and rotation reprojection error in meters and radians, or NaNs on error. Which is not the case as you pointed out.

Do not hesitate to submit a pull request if you have the time, it's a small fix that should be quickly and easily merged !

I don't know if this project is still maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants