Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace multiple team selector with multiple item selector #3368

Open
mathjazz opened this issue Sep 22, 2024 · 0 comments
Open

Replace multiple team selector with multiple item selector #3368

mathjazz opened this issue Sep 22, 2024 · 0 comments
Labels
enhancement P3 Default, possibly shipping in the following two quarters

Comments

@mathjazz
Copy link
Collaborator

mathjazz commented Sep 22, 2024

We use a custom widget for selecting multiple items. The generic multiple item selector should replace the more specific multiple team selector.

As part of this change, we should also modify the multiple item selector to use the <select> element for storing selected values rather than the current <input type=text> element and make corresponding changes to forms. (Update: Fixed in #3367).

@mathjazz mathjazz added P3 Default, possibly shipping in the following two quarters enhancement labels Sep 22, 2024
mathjazz added a commit that referenced this issue Sep 26, 2024
TLDR: Good riddance!

1. First and foremost, this patch replaces the unusual widget for selecting tag resources in Pontoon Admin with the multiple item selector that is more commonly used in Pontoon.

2. Secondly, the last bits of the old Tags Django code are now finally removed. It should now be much simpler to fix issues like #2122 and #2131.

3. Finally, the odd tag-admin frontend, which was only powering the old widget for selecting tag resources in Pontoon Admin, is now removed.

In total, the same (actually, I think it's much better) functionality uses some 95% smaller footprint.

Also included are a few smaller Pontoon Admin improvements:
- Unify dropdown style with the rest of the UI
- Use native date selector widget for target date
- Fix large margin in the external resources form
- Make multi item selector widget more semantic, which fixes the second part of #3368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement P3 Default, possibly shipping in the following two quarters
Projects
None yet
Development

No branches or pull requests

1 participant