-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace rouille with warp #2241
base: main
Are you sure you want to change the base?
Conversation
Wow, great work! Thanks in advance; Please ping me while you think this PR is ready. By the way, could you add @montekki as a co-author on this PR? I think it would be great to give them recognition. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
===========================================
+ Coverage 30.91% 41.09% +10.18%
===========================================
Files 53 55 +2
Lines 20112 20857 +745
Branches 9755 9844 +89
===========================================
+ Hits 6217 8571 +2354
- Misses 7922 8176 +254
+ Partials 5973 4110 -1863 ☔ View full report in Codecov by Sentry. |
I'll add montekki as a co-author. montekki, please let us know if you have any comments on this PR or if you would like to takeover the work. I'm not sure how to prepare this for a merge. Fixing the merge conflicts and getting the CI to pass was straightforward, but there are a lot of changes, and there's a risk for fallout. I wonder what's up with the freebsd tests though. |
I did some testing. For some reason I tested and it even works like this: This is the same reason why freebsd ci doesn't pass. I'll try to fix this issue. I don't have any useful logs yet. |
I found out that I need to create a |
All unit test for freebsd passed, we only have a We expect to see something like: Statistics of second buildtest
Compile requests 13
Compile requests executed 4
Cache hits 4
Cache hits (Rust) 4
Cache misses 0
Cache hits rate 100.00 %
Cache hits rate (Rust) 100.00 %
Cache timeouts 0
Cache read errors 0
Forced recaches 0
Cache write errors 0
Compilation failures 0
Cache errors 0
Non-cacheable compilations 0
Non-cacheable calls 8
Non-compilation calls 1
Unsupported compiler calls 0
Average cache write 0.000 s
Average compiler 0.000 s
Average cache read hit 0.000 s
Failed distributed compilations 0 |
Co-authored-by: Fedor Sakharov <[email protected]>
cf5f369
to
621bec5
Compare
I fixed freebsd test by creating let runtime = Runtime::new().context("Failed to create Tokio runtime")?;
runtime.block_on(async { http_scheduler.start().await })?; It was a problem that I noticed while testing on ubuntu too. |
Co-authored-by: Fedor Sakharov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @sylvestre would you like to take another look? |
src/util.rs
Outdated
// https://github.com/seanmonstar/reqwest/issues/1328 | ||
// https://github.com/briansmith/webpki/issues/54 | ||
#[cfg(any(feature = "dist-client", feature = "dist-server"))] | ||
pub fn native_tls_no_sni_client_builder<I, T>(root_certs: I) -> Result<reqwest::ClientBuilder> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xuanwo I just noticed that native_tls_no_sni_client_builder
method might not be needed anymore as seanmonstar/reqwest#1328 was already fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please feel free to remove it, thanks in advance.
Co-authored-by: Fedor Sakharov <[email protected]>
Part of porting changes from cachepot #1620, paritytech/cachepot#131