Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to .NET Core 2.0 / .NET Standard 2.0 #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewdouglas
Copy link

Upgraded to .NET Core 2.0 / .NET Standard 2.0. Swapped out MSTest with xUnit (all tests passing). Updated relative paths in TestConsoleApplication assembly to work with "dotnet run" command.

…h xUnit (all tests passing). Updated relative paths in TestConsoleApplication assembly to work with "dotnet run" command.
@fals
Copy link

fals commented Oct 4, 2018

Nice! Any chance to get this approved? We are moving a big part of our system to .NET Core and it's tightly coupled to this library :(

Copy link

@McTristan McTristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, compiles and works as expected in .net core projects. See no reason not to merge. Using xUnit over MSTest is out of scope the main task but all tests are green and passing so again, it might just be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants